[PATCH 1/7] KVM: s390: Drop unused and unreachable kvm_arch_vcpu_should_kick()

Steffen Eiden seiden at linux.ibm.com
Mon Nov 2 07:32:28 PST 2026


On Wed, Oct 28, 2026 at 12:02:53PM -0700, Sean Christopherson wrote:
> Drop s390's kvm_arch_vcpu_should_kick() stub as the one and only call site
> is wrapped with "#ifndef CONFIG_S390".

In the somehow near future I'll remove those #ifdefs and use the kick
stuff for kvm_arm64. The native s390 KVM then must at least keep an
(unused) symbol at hand. It seems that the compiler could not optimize
those calls away. So let's keep it there so I do not have to re-add it
soon.

	Steffen
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc at google.com>
> ---
>  arch/s390/kvm/s390/s390.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/arch/s390/kvm/s390/s390.c b/arch/s390/kvm/s390/s390.c
> index 18fb200f854a..9900a1a1c148 100644
> --- a/arch/s390/kvm/s390/s390.c
> +++ b/arch/s390/kvm/s390/s390.c
> @@ -3922,13 +3922,6 @@ bool kvm_arch_no_poll(struct kvm_vcpu *vcpu)
>  	return false;
>  }
>  
> -int kvm_arch_vcpu_should_kick(struct kvm_vcpu *vcpu)
> -{
> -	/* kvm common code refers to this, but never calls it */
> -	BUG();
> -	return 0;
> -}
> -
>  static int kvm_arch_vcpu_ioctl_get_one_reg(struct kvm_vcpu *vcpu,
>  					   struct kvm_one_reg *reg)
>  {
> -- 
> 2.56.0.313.g2479322e68-goog
> 



More information about the linux-arm-kernel mailing list