[RFC PATCH 09/11] soc: mediatek: dram-ecc: add a generic netlink event interface
santino.wang
santino.wang at mediatek.com
Mon Nov 2 01:23:31 PST 2026
From: Santino Wang <santino.wang at mediatek.com>
Multicast every decoded corrected and uncorrectable error to user
space through a generic netlink family, so a monitoring daemon can
subscribe to events instead of polling the counters.
Signed-off-by: Santino Wang <santino.wang at mediatek.com>
---
drivers/soc/mediatek/dram-ecc/core/Makefile | 1 +
.../mediatek/dram-ecc/core/ghes_notifier.c | 3 +
drivers/soc/mediatek/dram-ecc/core/main.c | 10 ++-
drivers/soc/mediatek/dram-ecc/core/netlink.c | 83 +++++++++++++++++++
drivers/soc/mediatek/dram-ecc/core/netlink.h | 14 ++++
include/uapi/linux/mtk_dram_ecc_netlink.h | 44 ++++++++++
6 files changed, 154 insertions(+), 1 deletion(-)
create mode 100644 drivers/soc/mediatek/dram-ecc/core/netlink.c
create mode 100644 drivers/soc/mediatek/dram-ecc/core/netlink.h
create mode 100644 include/uapi/linux/mtk_dram_ecc_netlink.h
diff --git a/drivers/soc/mediatek/dram-ecc/core/Makefile b/drivers/soc/mediatek/dram-ecc/core/Makefile
index 7c973831c9ef..1e2764914e9c 100644
--- a/drivers/soc/mediatek/dram-ecc/core/Makefile
+++ b/drivers/soc/mediatek/dram-ecc/core/Makefile
@@ -6,6 +6,7 @@ mtk_dram_ecc-y := \
main.o \
smc.o \
ghes_notifier.o \
+ netlink.o \
trace.o \
counters.o \
addresses.o \
diff --git a/drivers/soc/mediatek/dram-ecc/core/ghes_notifier.c b/drivers/soc/mediatek/dram-ecc/core/ghes_notifier.c
index a010ca652e86..701b0b28d358 100644
--- a/drivers/soc/mediatek/dram-ecc/core/ghes_notifier.c
+++ b/drivers/soc/mediatek/dram-ecc/core/ghes_notifier.c
@@ -28,6 +28,7 @@
#include "mtk_dram_ecc_event.h"
#include "ghes_notifier.h"
#include "counters.h"
+#include "netlink.h"
#include "policy/policy.h"
#include "trace.h"
@@ -256,6 +257,7 @@ static int mtk_ghes_vendor_cb(struct notifier_block *nb, unsigned long severity,
if (ret == NOTIFY_BAD)
pr_warn_ratelimited("mtk-dram-ecc: kernel client rejected CE event for spa=0x%llx\n",
evt.spa);
+ mtk_dram_ecc_netlink_notify(&evt);
} else {
unsigned long pfn = evt.spa >> PAGE_SHIFT;
@@ -305,6 +307,7 @@ static int mtk_ghes_vendor_cb(struct notifier_block *nb, unsigned long severity,
if (ret == NOTIFY_BAD)
pr_warn_ratelimited("mtk-dram-ecc: kernel client rejected UCE event for spa=0x%llx\n",
evt.spa);
+ mtk_dram_ecc_netlink_notify(&evt);
}
return NOTIFY_OK;
diff --git a/drivers/soc/mediatek/dram-ecc/core/main.c b/drivers/soc/mediatek/dram-ecc/core/main.c
index 315bdcbd650a..320631b3a044 100644
--- a/drivers/soc/mediatek/dram-ecc/core/main.c
+++ b/drivers/soc/mediatek/dram-ecc/core/main.c
@@ -10,6 +10,7 @@
#include "ghes_notifier.h"
#include "counters.h"
#include "addresses.h"
+#include "netlink.h"
#include "trace.h"
static struct class *mtk_dram_ecc_class;
@@ -37,10 +38,14 @@ static int __init mtk_dram_ecc_init(void)
goto err_class;
}
- ret = mtk_dram_ecc_policy_init(mtk_dram_ecc_dev);
+ ret = mtk_dram_ecc_netlink_init();
if (ret)
goto err_dev;
+ ret = mtk_dram_ecc_policy_init(mtk_dram_ecc_dev);
+ if (ret)
+ goto err_netlink;
+
ret = mtk_dram_ecc_counters_init(&mtk_dram_ecc_dev->kobj);
if (ret)
goto err_policy;
@@ -68,6 +73,8 @@ static int __init mtk_dram_ecc_init(void)
mtk_dram_ecc_counters_exit();
err_policy:
mtk_dram_ecc_policy_exit(mtk_dram_ecc_dev);
+err_netlink:
+ mtk_dram_ecc_netlink_exit();
err_dev:
device_destroy(mtk_dram_ecc_class, MKDEV(0, 0));
err_class:
@@ -86,6 +93,7 @@ static void __exit mtk_dram_ecc_exit(void)
mtk_dram_ecc_addresses_exit();
mtk_dram_ecc_counters_exit();
mtk_dram_ecc_policy_exit(mtk_dram_ecc_dev);
+ mtk_dram_ecc_netlink_exit();
device_destroy(mtk_dram_ecc_class, MKDEV(0, 0));
class_destroy(mtk_dram_ecc_class);
trace_mtk_dram_ecc_lifecycle(1);
diff --git a/drivers/soc/mediatek/dram-ecc/core/netlink.c b/drivers/soc/mediatek/dram-ecc/core/netlink.c
new file mode 100644
index 000000000000..bad96bbe4ed6
--- /dev/null
+++ b/drivers/soc/mediatek/dram-ecc/core/netlink.c
@@ -0,0 +1,83 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2026 MediaTek Inc.
+ */
+#include <linux/module.h>
+#include <linux/errno.h>
+#include <linux/netlink.h>
+#include <linux/printk.h>
+#include <net/genetlink.h>
+#include <uapi/linux/mtk_dram_ecc_netlink.h>
+
+#include "mtk_dram_ecc_event.h"
+#include "netlink.h"
+
+static const struct genl_multicast_group mtk_dram_ecc_mcgrps[] = {
+ { .name = MTK_DRAM_ECC_MCAST_GRP },
+};
+
+static struct genl_family mtk_dram_ecc_genl_family = {
+ .name = MTK_DRAM_ECC_GENL_NAME,
+ .version = MTK_DRAM_ECC_GENL_VERSION,
+ .maxattr = MTK_DRAM_ECC_ATTR_MAX,
+ .mcgrps = mtk_dram_ecc_mcgrps,
+ .n_mcgrps = ARRAY_SIZE(mtk_dram_ecc_mcgrps),
+ .module = THIS_MODULE,
+};
+
+int mtk_dram_ecc_netlink_init(void)
+{
+ return genl_register_family(&mtk_dram_ecc_genl_family);
+}
+
+void mtk_dram_ecc_netlink_exit(void)
+{
+ genl_unregister_family(&mtk_dram_ecc_genl_family);
+}
+
+void mtk_dram_ecc_netlink_notify(const struct mtk_dram_ecc_event *evt)
+{
+ struct sk_buff *skb;
+ void *hdr;
+ int ret;
+ u8 severity;
+
+ skb = genlmsg_new(NLMSG_GOODSIZE, GFP_ATOMIC);
+ if (!skb) {
+ pr_warn_ratelimited("mtk-dram-ecc: failed to allocate netlink event for spa=0x%llx\n",
+ evt->spa);
+ return;
+ }
+
+ hdr = genlmsg_put(skb, 0, 0, &mtk_dram_ecc_genl_family, 0,
+ MTK_DRAM_ECC_CMD_EVENT);
+ if (!hdr)
+ goto err;
+
+ severity = (evt->severity == MTK_DRAM_ECC_NOTIFY_CE) ?
+ MTK_DRAM_ECC_SEV_CE : MTK_DRAM_ECC_SEV_UCE;
+
+ if (nla_put_u64_64bit(skb, MTK_DRAM_ECC_ATTR_SPA, evt->spa,
+ MTK_DRAM_ECC_ATTR_UNSPEC) ||
+ nla_put_u8(skb, MTK_DRAM_ECC_ATTR_SEVERITY, severity) ||
+ nla_put_u8(skb, MTK_DRAM_ECC_ATTR_CHANNEL, evt->channel) ||
+ nla_put_u8(skb, MTK_DRAM_ECC_ATTR_SUBCHANNEL, evt->subchannel) ||
+ nla_put_u16(skb, MTK_DRAM_ECC_ATTR_RANK, evt->rank) ||
+ nla_put_u16(skb, MTK_DRAM_ECC_ATTR_BANK, evt->bank) ||
+ nla_put_u32(skb, MTK_DRAM_ECC_ATTR_ROW, evt->row) ||
+ nla_put_u16(skb, MTK_DRAM_ECC_ATTR_COLUMN, evt->column))
+ goto err;
+
+ genlmsg_end(skb, hdr);
+ ret = genlmsg_multicast(&mtk_dram_ecc_genl_family, skb, 0, 0,
+ GFP_ATOMIC);
+ if (ret && ret != -ESRCH)
+ pr_warn_ratelimited("mtk-dram-ecc: failed to publish netlink event for spa=0x%llx: %d\n",
+ evt->spa, ret);
+ return;
+
+err:
+ pr_warn_ratelimited("mtk-dram-ecc: failed to build netlink event for spa=0x%llx\n",
+ evt->spa);
+ nlmsg_free(skb);
+}
diff --git a/drivers/soc/mediatek/dram-ecc/core/netlink.h b/drivers/soc/mediatek/dram-ecc/core/netlink.h
new file mode 100644
index 000000000000..a2e64789d7d7
--- /dev/null
+++ b/drivers/soc/mediatek/dram-ecc/core/netlink.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2026 MediaTek Inc.
+ */
+#ifndef _MTK_DRAM_ECC_NETLINK_H_
+#define _MTK_DRAM_ECC_NETLINK_H_
+
+#include "mtk_dram_ecc_event.h"
+
+int mtk_dram_ecc_netlink_init(void);
+void mtk_dram_ecc_netlink_exit(void);
+void mtk_dram_ecc_netlink_notify(const struct mtk_dram_ecc_event *evt);
+
+#endif /* _MTK_DRAM_ECC_NETLINK_H_ */
diff --git a/include/uapi/linux/mtk_dram_ecc_netlink.h b/include/uapi/linux/mtk_dram_ecc_netlink.h
new file mode 100644
index 000000000000..8b4a77722bdb
--- /dev/null
+++ b/include/uapi/linux/mtk_dram_ecc_netlink.h
@@ -0,0 +1,44 @@
+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+/*
+ * Copyright (c) 2026 MediaTek Inc.
+ */
+#ifndef _UAPI_MTK_DRAM_ECC_NETLINK_H_
+#define _UAPI_MTK_DRAM_ECC_NETLINK_H_
+
+#define MTK_DRAM_ECC_GENL_NAME "mtk_dram_ecc"
+#define MTK_DRAM_ECC_GENL_VERSION 1
+#define MTK_DRAM_ECC_MCAST_GRP "events"
+
+/* Commands */
+enum mtk_dram_ecc_cmd {
+ MTK_DRAM_ECC_CMD_UNSPEC,
+ MTK_DRAM_ECC_CMD_EVENT,
+ __MTK_DRAM_ECC_CMD_MAX,
+};
+
+#define MTK_DRAM_ECC_CMD_MAX (__MTK_DRAM_ECC_CMD_MAX - 1)
+
+/*
+ * Attributes. rank, bank, row and column are the DRAM controller address
+ * fields of the error.
+ */
+enum mtk_dram_ecc_attr {
+ MTK_DRAM_ECC_ATTR_UNSPEC,
+ MTK_DRAM_ECC_ATTR_SPA, /* u64 - System Physical Address */
+ MTK_DRAM_ECC_ATTR_SEVERITY, /* u8 - 0=CE, 1=UCE */
+ MTK_DRAM_ECC_ATTR_CHANNEL, /* u8 - DRAM channel index */
+ MTK_DRAM_ECC_ATTR_SUBCHANNEL, /* u8 - DRAM sub-channel, 0 or 1 */
+ MTK_DRAM_ECC_ATTR_RANK, /* u16 - DRAMC rank address */
+ MTK_DRAM_ECC_ATTR_BANK, /* u16 - DRAMC bank address */
+ MTK_DRAM_ECC_ATTR_ROW, /* u32 - DRAMC row address */
+ MTK_DRAM_ECC_ATTR_COLUMN, /* u16 - DRAMC column address */
+ __MTK_DRAM_ECC_ATTR_MAX,
+};
+
+#define MTK_DRAM_ECC_ATTR_MAX (__MTK_DRAM_ECC_ATTR_MAX - 1)
+
+/* Severity values for MTK_DRAM_ECC_ATTR_SEVERITY */
+#define MTK_DRAM_ECC_SEV_CE 0
+#define MTK_DRAM_ECC_SEV_UCE 1
+
+#endif /* _UAPI_MTK_DRAM_ECC_NETLINK_H_ */
--
2.45.2
More information about the linux-arm-kernel
mailing list