[PATCH v2] clk: stm32: add support for reset_control_reset()
Brian Masney
masneyb at kernel.org
Sun Nov 1 18:22:31 PST 2026
Hi Gabriel,
> The STM32 RCC reset controller currently implements only .assert(),
> .deassert(), and .status().
>
> As a result, reset_control_reset() returns -ENOTSUPP, forcing consumers
> to open-code the assert / delay / deassert sequence.
> rs.
There's an extra 'rs.' here.
It looks like there's at least two in-tree consumers (stm32mp25_vpu_hw.c
and stm32-dma3.c) that call reset_control_reset() without checking the
result. Would it be worthwhile to call out in the commit message that
this will actually invoke the reset in those cases? I think that would
be useful information to have for someone deciding whether or not to
backport this to a downstream kernel.
>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez at foss.st.com>
> ---
> Changes in v2:
> - Increase the assert delay from 2 us to 50 us, a value that suits all
> STM32 IPs
I think this would be useful to also include in the commit message.
Brian
--
Brian Masney <masneyb at kernel.org>
More information about the linux-arm-kernel
mailing list