[PATCH] PCI: mt7621: Fix reset control leak on PHY initialization failure
Sreeraj S Kurup
sreekuttan2156239 at gmail.com
Sun Nov 1 00:01:21 PDT 2026
The PCIe port initialization code acquires a reset control handle using
of_reset_control_get_exclusive(). However, when PHY initialization or
power-on fails, the port is removed from the PCIe port list without
releasing the acquired reset control handle.
Since the reset control cleanup iterates over the remaining ports in
the list, the removed port's reset control handle is never released.
Call reset_control_put() before removing the failed port from the list
to ensure that the reset control resource is properly released.
Fixes a resource leak on PCIe PHY initialization failure.
Signed-off-by: Sreeraj S Kurup <sreekuttan2156239 at gmail.com>
---
drivers/pci/controller/pcie-mt7621.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
index 01ead2f92e87..1dcaa2829609 100644
--- a/drivers/pci/controller/pcie-mt7621.c
+++ b/drivers/pci/controller/pcie-mt7621.c
@@ -361,6 +361,7 @@ static int mt7621_pcie_init_ports(struct mt7621_pcie *pcie)
err = mt7621_pcie_init_port(port);
if (err) {
dev_err(dev, "initializing port %d failed\n", slot);
+ reset_control_put(port->pcie_rst);
list_del(&port->list);
}
}
--
2.55.0
More information about the linux-arm-kernel
mailing list