[RFC V2 13/14] arm64/mm: Add an abstraction level for tlbi_op

Linu Cherian linu.cherian at arm.com
Thu May 28 21:02:52 PDT 2026


Hi Ryan,

On Wed, May 27, 2026 at 03:50:10PM +0100, Ryan Roberts wrote:
> On 13/05/2026 05:45, Anshuman Khandual wrote:
> > From: Linu Cherian <linu.cherian at arm.com>
> > 
> > With FEAT_D128, a new instruction aka TLBIP is being introduced for the TLB
> > range operations which has an argument size of 128 bit.
> 
> nit: TLB range operations -> TLBI-by-range operations ?

Ack.

> 
> > 
> > Add an abstraction level to void (*tlbi_op)(u64 arg) helpers to support the
> > D128 variations when applicable.
> > 
> > No functional changes are introduced with this patch.
> > 
> > Signed-off-by: Linu Cherian <linu.cherian at arm.com>
> > Signed-off-by: Anshuman Khandual <anshuman.khandual at arm.com>
> > ---
> >  arch/arm64/include/asm/tlbflush.h | 70 ++++++++++++++++---------------
> >  1 file changed, 37 insertions(+), 33 deletions(-)
> > 
> > diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h
> > index c0bf5b398041..361d74ef8016 100644
> > --- a/arch/arm64/include/asm/tlbflush.h
> > +++ b/arch/arm64/include/asm/tlbflush.h
> > @@ -162,49 +162,53 @@ static inline void sme_dvmsync_batch(struct arch_tlbflush_unmap_batch *batch)
> >  
> >  #define TLBI_TTL_UNKNOWN	INT_MAX
> >  
> > -typedef void (*tlbi_op)(u64 arg);
> > +typedef u64 tlbi_args_t;
> 
> nit: tlbi_args_t -> tlbi_arg_t ?

Ack.


--
Thanks,
Linu Cherian.



More information about the linux-arm-kernel mailing list