[PATCH v7 06/11] iommu/arm-smmu-v3: Handle gerror during suspend

[Pranjal Shrivastava]

On Thu, May 28, 2026 at 11:53:42AM -0700, Nicolin Chen wrote:
> On Wed, May 27, 2026 at 10:14:02PM +0000, Pranjal Shrivastava wrote:
> > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > index 93cee32f6c99..191b5b5b805c 100644
> > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> > @@ -2257,10 +2257,9 @@ static irqreturn_t arm_smmu_priq_thread(int irq, void *dev)
> >  
> >  static int arm_smmu_device_disable(struct arm_smmu_device *smmu);
> >  
> > -static irqreturn_t arm_smmu_gerror_handler(int irq, void *dev)
> > +static irqreturn_t arm_smmu_handle_gerror(struct arm_smmu_device *smmu)
> 
> We don't need a lock because the new caller would disable the IRQ.
> 
> Yet, maybe add a line of comments:
> /* Lockless; must ensure that there are no concurrent callers */

Ack, I'll add the comment.

> 
> Otherwise,
> Reviewed-by: Nicolin Chen <nicolinc at nvidia.com>

Thanks!
Praan