[PATCH 07/18] arm64: fpsimd: Use assembler for SVE instructions
Mark Rutland
mark.rutland at arm.com
Wed May 27 09:10:37 PDT 2026
On Wed, May 27, 2026 at 01:58:09PM +0100, Vladimir Murzin wrote:
> On 5/21/26 14:25, Mark Rutland wrote:
> > /* STR (vector): STR Z\nz, [X\nxbase, #\offset, MUL VL] */
>
> Nitpick:
>
> all these comments now redundant and just repeat the code... I know they are gone by
> the end of the series :)
Yep; if I weren't deleting them later I'd remove them here.
> > .macro _sve_str_v nz, nxbase, offset=0
> > - _sve_check_zreg \nz
> > - _check_general_reg \nxbase
> > - _check_num (\offset), -0x100, 0xff
> > - .inst 0xe5804000 \
> > - | (\nz) \
> > - | ((\nxbase) << 5) \
> > - | (((\offset) & 7) << 10) \
> > - | (((\offset) & 0x1f8) << 13)
> > + .arch_extension sve
> > + str z\nz, [X\nxbase, #\offset, MUL VL]
> > .endm
[...]
> > /* WRFFR P\np.B */
> > .macro _sve_wrffr np
> > - _sve_check_preg \np
> > - .inst 0x25289000 \
> > - | ((\np) << 5)
>
> Missing ".arch_extension sve"?
>
> > + wrffr p\np\().b
> > .endm
Sorry about that; fixed now.
Mark.
More information about the linux-arm-kernel
mailing list