[PATCH] spi: aspeed: Replace VLA parameter with flat pointer in calibration helper

Chin-Ting Kuo chin-ting_kuo at aspeedtech.com
Tue May 19 05:43:44 PDT 2026


Hi Mark,

Thanks for the review.

> -----Original Message-----
> From: Mark Brown <broonie at kernel.org>
> Sent: Tuesday, May 19, 2026 7:04 PM
> Subject: Re: [PATCH] spi: aspeed: Replace VLA parameter with flat pointer in
> calibration helper
> 
> On Mon, May 18, 2026 at 05:57:08PM +0800, Chin-Ting Kuo wrote:
> 
> > -			while (k < cols && buf[i][k])
> > +			while (k < cols && buf[i * cols + k])
> 
> This really needs () to make it clear what's going on; the precedence is well
> defined but not everyone is going to know that off the top of their head.

Okay, below change will be added in the next patch version.
while (k < cols && buf[(i * cols) + k])


Chin-Ting



More information about the linux-arm-kernel mailing list