[PATCH v4 3/5] firmware: raspberrypi: register nvmem driver

[Gregor Herburger]

On Tue, May 19, 2026 at 11:15:59AM +0200, Thomas Weißschuh wrote:
> On Fri, May 08, 2026 at 04:42:46PM +0200, Gregor Herburger wrote:
> > The Raspberry Pi firmware exposes two regions with otp registers. The
> > first region called "customer otp" is available on all Raspberry Pi
> > models. The second is only available on the Raspberry Pi 5 (bcm2712).
> 
> (...)
> 
> > @@ -327,12 +371,25 @@ static void rpi_firmware_remove(struct platform_device *pdev)
> >  	rpi_hwmon = NULL;
> >  	platform_device_unregister(rpi_clk);
> >  	rpi_clk = NULL;
> > +	platform_device_unregister(rpi_otp_customer);
> > +	rpi_otp_customer = NULL;
> > +	if (rpi_otp_private)
> 
> This check looks unnecessary.

Looking at platform_device_unregister again it does not do anything when
rpi_otp_private is NULL so i will drop the if.

> 
> > +		platform_device_unregister(rpi_otp_private);
> > +
> > +	rpi_otp_private = NULL;
> >  
> >  	rpi_firmware_put(fw);
> >  }

Regards
Gregor