[PATCH v6 12/12] powercap: arm_scmi: Synthetic zone enable/disable
Philip Radford
philip.radford at arm.com
Mon May 18 06:52:34 PDT 2026
Add functionality to disable and enable the synthetic zone which
also affects the immediate children of the synthetic zone by applying
the same command to them.
Signed-off-by: Philip Radford <philip.radford at arm.com>
---
V5->V6
- Added use of to_scmi_powercap_root macro
- Changed instance_root_set_enable_state to bail out on any error
- Changed logic in instance_root_get_enable to not check child states
---
drivers/powercap/arm_scmi_powercap.c | 128 +++++++++++++++++++++++++++
1 file changed, 128 insertions(+)
diff --git a/drivers/powercap/arm_scmi_powercap.c b/drivers/powercap/arm_scmi_powercap.c
index f1cb25a408bb..d911e623e2d7 100644
--- a/drivers/powercap/arm_scmi_powercap.c
+++ b/drivers/powercap/arm_scmi_powercap.c
@@ -36,6 +36,7 @@ struct scmi_powercap_zone {
struct scmi_powercap_root {
unsigned int num_zones;
+ bool enabled;
struct scmi_powercap_zone *spzones;
struct list_head *registered_zones;
struct list_head scmi_zones;
@@ -276,6 +277,127 @@ static int instance_root_release(struct powercap_zone *pz)
return 0;
}
+static int instance_root_read_children_enable_state(struct scmi_powercap_root *pr,
+ bool *mode)
+{
+ struct scmi_powercap_zone *child;
+ bool enabled;
+ int i, ret;
+
+ if (!pr || !mode)
+ return -EINVAL;
+
+ *mode = true;
+
+ for (i = 0; i < pr->num_zones; i++) {
+ child = &pr->spzones[i];
+
+ if (!child->registered || child->invalid)
+ continue;
+ if (child->info->parent_id != SCMI_POWERCAP_ROOT_ZONE_ID)
+ continue;
+
+ ret = powercap_ops->cap_enable_get(child->ph, child->info->id, &enabled);
+ if (ret)
+ return ret;
+
+ if (!enabled) {
+ *mode = false;
+ return 0;
+ }
+ }
+
+ return 0;
+}
+
+static int instance_root_set_enable_state(struct powercap_zone *pz, bool enable)
+{
+ struct scmi_powercap_zone *child;
+ struct scmi_powercap_root *pr = to_scmi_powercap_root(pz);
+ int i, ret;
+ bool *prev_state;
+
+ if (!pz)
+ return -EINVAL;
+
+ prev_state = kcalloc(pr->num_zones, sizeof(*prev_state), GFP_KERNEL);
+ if (!prev_state)
+ return -ENOMEM;
+
+ for (i = 0; i < pr->num_zones; i++) {
+ child = &pr->spzones[i];
+
+ if (!child->registered || child->invalid)
+ continue;
+ if (child->info->parent_id != SCMI_POWERCAP_ROOT_ZONE_ID)
+ continue;
+
+ ret = powercap_ops->cap_enable_get(child->ph, child->info->id,
+ &prev_state[i]);
+
+ if (ret)
+ goto revert;
+
+ if (prev_state[i] == enable)
+ continue;
+
+ ret = powercap_ops->cap_enable_set(child->ph, child->info->id, enable);
+
+ if (ret) {
+ dev_err(child->dev, "failed to %s zone %s: %d\n",
+ enable ? "enable" : "disable",
+ child->info->name, ret);
+ goto revert;
+ }
+ }
+
+ kfree(prev_state);
+ return 0;
+
+revert:
+ while (--i >= 0) {
+ child = &pr->spzones[i];
+
+ if (!child->registered || child->invalid)
+ continue;
+ if (child->info->parent_id != SCMI_POWERCAP_ROOT_ZONE_ID)
+ continue;
+ if (!child->info->cpli[0].cap_config)
+ continue;
+ if (prev_state[i] == enable)
+ continue;
+
+ powercap_ops->cap_enable_set(child->ph, child->info->id,
+ prev_state[i]);
+ }
+
+ kfree(prev_state);
+ return ret;
+}
+
+static int instance_root_set_enable(struct powercap_zone *pz, bool mode)
+{
+ struct scmi_powercap_root *pr = to_scmi_powercap_root(pz);
+ int ret;
+
+ ret = instance_root_set_enable_state(pz, mode);
+ if (!ret)
+ pr->enabled = mode;
+
+ return ret;
+}
+
+static int instance_root_get_enable(struct powercap_zone *pz, bool *mode)
+{
+ struct scmi_powercap_root *pr = to_scmi_powercap_root(pz);
+
+ if (!pz || !mode)
+ return -EINVAL;
+
+ *mode = pr->enabled;
+ return 0;
+}
+
static int instance_root_get_power_uw(struct powercap_zone *pz, u64 *power_uw)
{
struct scmi_powercap_root *pr = to_scmi_powercap_root(pz);
@@ -324,6 +446,8 @@ static const struct powercap_zone_ops instance_root_ops = {
.get_max_power_range_uw = scmi_powercap_get_max_power_range_uw,
.get_power_uw = instance_root_get_power_uw,
.release = instance_root_release,
+ .set_enable = instance_root_set_enable,
+ .get_enable = instance_root_get_enable,
};
static const struct powercap_zone_constraint_ops instance_root_const_ops = {
@@ -600,6 +724,10 @@ static int scmi_powercap_probe(struct scmi_device *sdev)
if (ret)
return ret;
+ ret = instance_root_read_children_enable_state(pr, &pr->enabled);
+ if (ret)
+ return ret;
+
dev_set_drvdata(dev, pr);
return ret;
--
2.47.3
More information about the linux-arm-kernel
mailing list