[PATCH] ARM: PCI: expand single-line pci_common_init() wrapper function

Ethan Nelson-Moore enelsonmoore at gmail.com
Sun May 17 21:20:46 PDT 2026


Hi, Andrew,

On Sun, May 17, 2026 at 8:42 PM Andrew Lunn <andrew at lunn.ch> wrote:
> Nobody seems to call pci_common_init_dev() without passing NULL. So i
> think it makes more sense to rename pci_common_init_dev() to
> pci_common_init() and drop struct device *parent parameter. You then
> only need to change pci.h and bios32.c.

I considered that, but decided against it because it would prevent the
code from easily being updated to pass a parent parameter in the
future. However, given the age of the affected platforms, that is
unlikely to happen, so your approach might make more sense. What do
you think?

Ethan



More information about the linux-arm-kernel mailing list