[PATCH net-next v2 3/3] net: macb: add TX stall watchdog to recover from lost TCOMP interrupts
Lukasz Raczylo
lukasz at raczylo.com
Fri May 15 06:08:49 PDT 2026
self NACK
This patch references netdev_warn_ratelimited(), which does not exist
in mainline net-next or in raspberrypi/linux rpi-6.18.y -- no
netdev_*_ratelimited() helper is defined. I confused it with the
existing net_warn_ratelimited() / pr_warn_ratelimited() /
dev_warn_ratelimited() family while authoring v2. The result fails
to build with implicit-function-declaration on every kernel that
includes <linux/netdevice.h>.
The bug was caught by John Laur via an independent build test on the
Talos Linux Pi 5 build and reported at:
https://github.com/siderolabs/sbc-raspberrypi/issues/91#issuecomment-4456874307
I incorrectly tried to address this by sending a standalone fix-up
patch to netdev as:
https://lore.kernel.org/netdev/20260515095336.92237-1-lukasz@raczylo.com/T/
Andrew Lunn pointed out that this is not the correct workflow on
netdev -- the right thing to do is self-NACK the broken patch on the
original thread, wait 24 hours, and resend the whole series as v3.
Apologies for the noise; this reply is that self-NACK.
Patches 1/3 and 2/3 do not reference netdev_warn_ratelimited() and
are unaffected by this build break; their content stands. In v3:
* 3/3 will use `if (printk_ratelimit()) netdev_warn(...)` in place
of the non-existent netdev_warn_ratelimited(), matching the
semantics intended in v2 (bounded log noise, retains the netdev
prefix in the message).
* The standalone fix-up patch above (Message-ID
<20260515095336.92237-1-lukasz at raczylo.com>) should be considered
withdrawn -- v3 supersedes it.
* Cover letter will carry a changelog noting the v2->v3 delta and
this self-NACK.
I will send v3 no earlier than 24 hours from this message, per
Andrew's guidance and standard netdev practice.
Signed-off-by: Lukasz Raczylo <lukasz at raczylo.com>
More information about the linux-arm-kernel
mailing list