[PATCH v2 08/11] m68k: stmark2: add mcf5441x DAC platform devices

Andy Shevchenko andriy.shevchenko at intel.com
Wed May 13 13:16:16 PDT 2026


On Wed, May 13, 2026 at 11:14:32AM +0200, Angelo Dureghello wrote:

> Add mcf5441x DAC platform devices.

...

> +static struct resource dac0_resource[] = {
> +	DEFINE_RES_MEM(MCFDAC_BASE0, 0x100),
> +};
> +
> +static struct platform_device dac0_device = {
> +	.name = "mcf54415_dac",
> +	.id = 0,
> +	.num_resources = ARRAY_SIZE(dac0_resource),
> +	.resource = dac0_resource,
> +};

It can be

static struct resource dac0_resource = DEFINE_RES_MEM(MCFDAC_BASE0, 0x100);

static struct platform_device dac0_device = {
	.name = "mcf54415_dac",
	.id = 0,
	.num_resources = 1,
	.resource = &dac0_resource,
};

...

Same for the rest. But I haven't seen the followups and don't know if those
structures are going to be expanded. The commit message doesn't say anything
about that. So I assume my suggestion valid.

-- 
With Best Regards,
Andy Shevchenko





More information about the linux-arm-kernel mailing list