[PATCH 4/5] arm64: dts: freescale: imx952-evk: Add IMX-AUD-IO board support

[Chancel Liu]

> > diff --git a/arch/arm64/boot/dts/freescale/imx952-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> > index 62d1c1c7c501..bb1d8d5f5fcf 100644
> > --- a/arch/arm64/boot/dts/freescale/imx952-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> > @@ -43,6 +43,17 @@ aliases {
> >  		spi6 = &lpspi7;
> >  	};
> >
> > +	aud_io_conn: aud-io-connector {
> > +		compatible = "fsl,io-connector";
> > +		gpio-controller;
> > +		#gpio-cells = <2>;
> > +		gpio-map = <0 0 &pcal6416 8 1>;
> > +		gpio-map-mask = <0xff 0x0>;
> > +		gpio-map-pass-thru = <0x0 0x1>;
> 
> According to the include/dt-bindings/gpio/gpio.h, there 6 bits definition for
> GPIO flags, here you just pass through bit 0, should it better to use the
> following value:
> gpio-map-pass-thru = <0x0 0x3f>;
> 
> Regards
> Haibo Chen

Good point. 
For this connector on the base board, the intention is to only pass
through the polarity flag (bit0) in the GPIO flags cell. Other standard
GPIO flags are fixed on the base board side and won't be propagated
across this connector. 

To avoid confusion, I'll add a short comment in the DT to explicitly
document that only the polarity bit is passed for GPIO flags on this
connector.

Regards, 
Chancel Liu