[PATCH v4] coresight: fix missing error code when trace ID is invalid

Suzuki K Poulose suzuki.poulose at arm.com
Tue May 12 08:40:35 PDT 2026


On Tue, 12 May 2026 09:56:07 +0800, Jie Gan wrote:
> When coresight_path_assign_trace_id() cannot assign a valid trace ID,
> coresight_enable_sysfs() takes the err_path goto with ret still 0,
> returning success to the caller despite no trace session being started.
> 
> Change coresight_path_assign_trace_id() to return int, moving the
> IS_VALID_CS_TRACE_ID() check inside it so it returns -EINVAL on failure
> and 0 on success. Update both callers to propagate this return value
> directly instead of inspecting path->trace_id after the call.
> 
> [...]

Applied, thanks!

[1/1] coresight: fix missing error code when trace ID is invalid
      https://git.kernel.org/coresight/c/f4526ffee6ff

Best regards,
-- 
Suzuki K Poulose <suzuki.poulose at arm.com>



More information about the linux-arm-kernel mailing list