[PATCH v6 1/2] media: dt-bindings: Add CSI Pixel Formatter DT bindings

[G.N. Zhou (OSS)]

Hi Macro,

Thank you for the review and the valid point!

> -----Original Message-----
> From: Marco Felsch <m.felsch at pengutronix.de>
> Sent: Monday, May 11, 2026 7:46 PM
> To: G.N. Zhou (OSS) <guoniu.zhou at oss.nxp.com>
> Cc: Mauro Carvalho Chehab <mchehab at kernel.org>; Rob Herring
> <robh at kernel.org>; Krzysztof Kozlowski <krzk+dt at kernel.org>; Conor Dooley
> <conor+dt at kernel.org>; Shawn Guo <shawnguo at kernel.org>; Sascha Hauer
> <s.hauer at pengutronix.de>; Pengutronix Kernel Team
> <kernel at pengutronix.de>; Fabio Estevam <festevam at gmail.com>; Laurent
> Pinchart <laurent.pinchart at ideasonboard.com>; Frank Li <frank.li at nxp.com>;
> imx at lists.linux.dev; Krzysztof Kozlowski
> <krzysztof.kozlowski at oss.qualcomm.com>; devicetree at vger.kernel.org; linux-
> kernel at vger.kernel.org; G.N. Zhou <guoniu.zhou at nxp.com>; linux-arm-
> kernel at lists.infradead.org; linux-media at vger.kernel.org
> Subject: Re: [PATCH v6 1/2] media: dt-bindings: Add CSI Pixel Formatter DT
> bindings
> 
> [You don't often get email from m.felsch at pengutronix.de. Learn why this is
> important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> On 26-05-11, Guoniu Zhou wrote:
> > From: Guoniu Zhou <guoniu.zhou at nxp.com>
> >
> > The i.MX9 CSI pixel formatting module uses packet info, pixel and
> > non-pixel data from the CSI-2 host controller and reformat them to
> > match Pixel Link(PL) definition.
> 
> Sorry for chiming in very late, but can you please provide on which
> i.MX9 devices this formatting module is present? I've checked the i.MX93
> reference manual and found no info instead I found a CAMERA_MUX register
> which does something similiar but is not the same. Please provide a more
> specific compatible if this IP is only be present on i.MX95 devices.

You're right. I initially used "imx9" because this CSI formatter  IP is present on
both i.MX95 and i.MX952 (not on i.MX93 as you correctly noted). However, I
agree this naming is confusing and could mislead people  into thinking it's available
across all i.MX9 series devices.

I'll change the compatible to "fsl,imx95-csi-formatter" as the current driver 
only supports i.MX95. When i.MX952 support is added in the future, we can 
extend the compatible string accordingly (e.g., using "fsl,imx952-csi-formatter" 
with "fsl,imx95-csi-formatter" as fallback if they're compatible).

Thanks again for catching this!

Best Regards
G.N Zhou

> 
> Regards,
>   Marco
> 
> > Reviewed-by: Frank Li <Frank.Li at nxp.com>
> > Reviewed-by: Krzysztof Kozlowski
> > <krzysztof.kozlowski at oss.qualcomm.com>
> > Signed-off-by: Guoniu Zhou <guoniu.zhou at nxp.com>
> > ---
> >  .../bindings/media/fsl,imx9-csi-formatter.yaml     | 87
> ++++++++++++++++++++++
> >  1 file changed, 87 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/fsl,imx9-csi-formatter.yaml
> > b/Documentation/devicetree/bindings/media/fsl,imx9-csi-formatter.yaml
> > new file mode 100644
> > index 000000000000..774d37d2b987
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/fsl,imx9-csi-formatter.y
> > +++ aml
> > @@ -0,0 +1,87 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/fsl,imx9-csi-formatter.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: i.MX9 CSI Pixel Formatter
> > +
> > +maintainers:
> > +  - Guoniu Zhou <guoniu.zhou at nxp.com>
> > +
> > +description:
> > +  The CSI pixel formatting module uses packet info, pixel and
> > +non-pixel
> > +  data from the CSI-2 host controller and reformat them to match
> > +Pixel
> > +  Link(PL) definition.
> > +
> > +properties:
> > +  compatible:
> > +    const: fsl,imx9-csi-formatter
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  power-domains:
> > +    maxItems: 1
> > +
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +
> > +    properties:
> > +      port at 0:
> > +        $ref: /schemas/graph.yaml#/$defs/port-base
> > +        unevaluatedProperties: false
> > +        description: MIPI CSI-2 RX IDI interface
> > +
> > +        properties:
> > +          endpoint:
> > +            $ref: video-interfaces.yaml#
> > +            unevaluatedProperties: false
> > +
> > +      port at 1:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description: Pixel Link Interface
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - power-domains
> > +  - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/nxp,imx95-clock.h>
> > +
> > +    formatter at 20 {
> > +        compatible = "fsl,imx9-csi-formatter";
> > +        reg = <0x20 0x100>;
> > +        clocks = <&cameramix_csr IMX95_CLK_CAMBLK_CSI2_FOR0>;
> > +        power-domains = <&scmi_devpd 3>;
> > +
> > +        ports {
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            port at 0 {
> > +                reg = <0>;
> > +
> > +                endpoint {
> > +                    remote-endpoint = <&mipi_csi_0_out>;
> > +                };
> > +            };
> > +
> > +            port at 1 {
> > +                reg = <1>;
> > +
> > +                endpoint {
> > +                    remote-endpoint = <&isi_in_2>;
> > +                };
> > +            };
> > +        };
> > +    };
> >
> > --
> > 2.34.1
> >
> >
> >
> 
> --
> #gernperDu
> #CallMeByMyFirstName
> 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |