[PATCH 2/5] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse

[Linus Walleij]

On Fri, May 8, 2026 at 5:26 PM Jun Yan <jerrysteve1101 at gmail.com> wrote:

> 1. Per IS31FL319x datasheet [1], the hardware shutdown pin (SDB) is
> active-low.

So that means that driving the line low will shut down the hardware.

> -       is31->shutdown_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_HIGH);
> +       is31->shutdown_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_LOW);

Add a comment here that this will in fact drive the line high,
because the GPIO line will be flagged as GPIO_ACTIVE_LOW
in the provider (such as the device tree).

At least write this in the commit message, it's a missing piece
that helps readers understand what is going on.

Have you checked any existing device trees so you don't
break something here?

If you're breaking platforms you may need a fixup in
drivers/gpio/gpiolib-of.c to force the consumer active
low for legacy device trees.

Yours,
Linus Walleij

Yours,
Linus Walleij