[PATCH] arm: orion5x: correct machine ID check in mss2_pci_init() to use DT
Ethan Nelson-Moore
enelsonmoore at gmail.com
Fri May 8 19:19:34 PDT 2026
The mss2_pci_init() function contains a check for the ARM machine ID
via the machine_is_mss2() macro. This check is incorrect because the
machine concerned now supports only FDT booting, which does not use
machine IDs, and therefore it will always fail. The machine was
converted to FDT booting in commit fbf04d814d0a ("ARM: orion5x: convert
Maxtor Shared Storage II to the Device Tree"). To resolve this issue,
use of_machine_is_compatible() instead.
Fixes: fbf04d814d0a ("ARM: orion5x: convert Maxtor Shared Storage II to the Device Tree")
Cc: stable at vger.kernel.org
Signed-off-by: Ethan Nelson-Moore <enelsonmoore at gmail.com>
---
arch/arm/mach-orion5x/board-mss2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-orion5x/board-mss2.c b/arch/arm/mach-orion5x/board-mss2.c
index 9e3d69891d2f..322ae29d05aa 100644
--- a/arch/arm/mach-orion5x/board-mss2.c
+++ b/arch/arm/mach-orion5x/board-mss2.c
@@ -10,7 +10,7 @@
#include <linux/platform_device.h>
#include <linux/pci.h>
#include <linux/irq.h>
-#include <asm/mach-types.h>
+#include <linux/of.h>
#include <asm/mach/arch.h>
#include <asm/mach/pci.h>
#include "orion5x.h"
@@ -47,7 +47,7 @@ static struct hw_pci mss2_pci __initdata = {
static int __init mss2_pci_init(void)
{
- if (machine_is_mss2())
+ if (of_machine_is_compatible("maxtor,shared-storage-2"))
pci_common_init(&mss2_pci);
return 0;
--
2.43.0
More information about the linux-arm-kernel
mailing list