[PATCH 01/11] soc: ti: knav_qmss: Remove remaining redundant ENOMEM printks
Nishanth Menon
nm at ti.com
Fri May 8 08:32:01 PDT 2026
Commit 168d2fb78055 ("soc: ti: knav_qmss: Remove ENOMEM printks")
removed redundant dev_err() calls after allocation failures in
knav_queue_setup_regions, knav_queue_init_qmgrs and
knav_queue_init_pdsps, but missed three further instances in
knav_pool_create, knav_queue_setup_region and knav_setup_queue_range.
Remove the missed instances.
Signed-off-by: Nishanth Menon <nm at ti.com>
---
Cc: Krzysztof Kozlowski <krzysztof.kozlowski at oss.qualcomm.com>
drivers/soc/ti/knav_qmss_queue.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index 86d7a9c9ae01..e87a42734f25 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -769,10 +769,8 @@ void *knav_pool_create(const char *name,
return ERR_PTR(-ENODEV);
pool = devm_kzalloc(kdev->dev, sizeof(*pool), GFP_KERNEL);
- if (!pool) {
- dev_err(kdev->dev, "out of memory allocating pool\n");
+ if (!pool)
return ERR_PTR(-ENOMEM);
- }
for_each_region(kdev, reg_itr) {
if (reg_itr->id != region_id)
@@ -1025,10 +1023,8 @@ static void knav_queue_setup_region(struct knav_device *kdev,
region->dma_end = region->dma_start + size;
pool = devm_kzalloc(kdev->dev, sizeof(*pool), GFP_KERNEL);
- if (!pool) {
- dev_err(kdev->dev, "out of memory allocating dummy pool\n");
+ if (!pool)
goto fail;
- }
pool->num_desc = 0;
pool->region_offset = region->num_desc;
list_add(&pool->region_inst, ®ion->pools);
@@ -1211,10 +1207,8 @@ static int knav_setup_queue_range(struct knav_device *kdev,
int ret, i;
range = devm_kzalloc(dev, sizeof(*range), GFP_KERNEL);
- if (!range) {
- dev_err(dev, "out of memory allocating range\n");
+ if (!range)
return -ENOMEM;
- }
range->kdev = kdev;
range->name = knav_queue_find_name(node);
--
2.47.0
More information about the linux-arm-kernel
mailing list