[PATCH v2 2/3] ASoC: pxa2xx: push gpio usage into arch code

Andy Shevchenko andriy.shevchenko at intel.com
Wed May 6 01:15:12 PDT 2026


On Wed, May 06, 2026 at 08:58:21AM +0900, Mark Brown wrote:
> On Tue, May 05, 2026 at 10:24:25PM +0200, Arnd Bergmann wrote:

...

> >  #include <sound/pcm.h>
> >  #include <sound/ac97_codec.h>
> >  
> > -extern void pxa27x_configure_ac97reset(int reset_gpio, bool to_gpio);
> > +extern void pxa27x_configure_ac97reset(struct gpio_desc *reset_gpio, bool to_gpio);
> >  
> >  #endif
> 
> You're adding a use of struct gpio_desc but not including the header for
> it or declaring it.  Which won't really matter here but still.

Usually forward declaration is enough (for clarity).

struct gpio_desc;

and we do that in many headers.

-- 
With Best Regards,
Andy Shevchenko





More information about the linux-arm-kernel mailing list