[PATCH v4 5/5] Allwinner: A523: add support for A523 THS0/1 controllers

Chen-Yu Tsai wens at kernel.org
Tue May 5 07:06:07 PDT 2026


Hi,

On Mon, May 4, 2026 at 1:04 PM Mikhail Kalashnikov <iuncuim at gmail.com> wrote:

The correct format for the patch subject should be:

    arm64: dts: allwinner: sun55i: add thermal sensors

> The A523 processor has two temperature controllers, THS0 and THS1.
> THS0 has only one temperature sensor, which is located in the DRAM.
                                                                ^
                                                          "DRAM controller".

>
> THS1 does have 3 sensors:
> ths1_0 - "big" cores
> ths1_1 - "little" cores
> ths1_2 - gpu
>
> Add the thermal sensor configuration and the thermal zones.
> Trips temperature, polling-delay and sustainable-power parameters are
> derived from the manufacturer's BSP.
>
> Signed-off-by: Mikhail Kalashnikov <iuncuim at gmail.com>
> ---
>  .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 154 ++++++++++++++++++
>  1 file changed, 154 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 5afa8d92a..288a4710b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -11,6 +11,7 @@
>  #include <dt-bindings/reset/sun55i-a523-r-ccu.h>
>  #include <dt-bindings/power/allwinner,sun55i-a523-ppu.h>
>  #include <dt-bindings/power/allwinner,sun55i-a523-pck-600.h>
> +#include <dt-bindings/thermal/thermal.h>
>
>  / {
>         interrupt-parent = <&gic>;
> @@ -26,6 +27,7 @@ cpu0: cpu at 0 {
>                         device_type = "cpu";
>                         reg = <0x000>;
>                         enable-method = "psci";
> +                       #cooling-cells = <2>;
>                 };
>
>                 cpu1: cpu at 100 {
> @@ -33,6 +35,7 @@ cpu1: cpu at 100 {
>                         device_type = "cpu";
>                         reg = <0x100>;
>                         enable-method = "psci";
> +                       #cooling-cells = <2>;
>                 };
>
>                 cpu2: cpu at 200 {
> @@ -40,6 +43,7 @@ cpu2: cpu at 200 {
>                         device_type = "cpu";
>                         reg = <0x200>;
>                         enable-method = "psci";
> +                       #cooling-cells = <2>;
>                 };
>
>                 cpu3: cpu at 300 {
> @@ -47,6 +51,7 @@ cpu3: cpu at 300 {
>                         device_type = "cpu";
>                         reg = <0x300>;
>                         enable-method = "psci";
> +                       #cooling-cells = <2>;
>                 };
>
>                 cpu4: cpu at 400 {
> @@ -54,6 +59,7 @@ cpu4: cpu at 400 {
>                         device_type = "cpu";
>                         reg = <0x400>;
>                         enable-method = "psci";
> +                       #cooling-cells = <2>;
>                 };
>
>                 cpu5: cpu at 500 {
> @@ -61,6 +67,7 @@ cpu5: cpu at 500 {
>                         device_type = "cpu";
>                         reg = <0x500>;
>                         enable-method = "psci";
> +                       #cooling-cells = <2>;
>                 };
>
>                 cpu6: cpu at 600 {
> @@ -68,6 +75,7 @@ cpu6: cpu at 600 {
>                         device_type = "cpu";
>                         reg = <0x600>;
>                         enable-method = "psci";
> +                       #cooling-cells = <2>;
>                 };
>
>                 cpu7: cpu at 700 {
> @@ -75,6 +83,7 @@ cpu7: cpu at 700 {
>                         device_type = "cpu";
>                         reg = <0x700>;
>                         enable-method = "psci";
> +                       #cooling-cells = <2>;
>                 };
>         };
>
> @@ -565,12 +574,46 @@ dma: dma-controller at 3002000 {
>                         #dma-cells = <1>;
>                 };
>
> +               ths1: thermal-sensor at 2009400 {
> +                       compatible = "allwinner,sun55i-a523-ths1";
> +                       reg = <0x02009400 0x400>;
> +                       interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_GPADC1>;
> +                       clock-names = "bus", "mod";
> +                       resets = <&ccu RST_BUS_THS>;
> +                       nvmem-cells = <&ths_calibration0>, <&ths_calibration1>;
> +                       nvmem-cell-names = "calibration",
> +                                    "calibration-second-part";
> +                       #thermal-sensor-cells = <1>;
> +               };
> +
> +               ths0: thermal-sensor at 200a000 {
> +                       compatible = "allwinner,sun55i-a523-ths0";
> +                       reg = <0x0200a000 0x400>;
> +                       interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_GPADC0>;
> +                       clock-names = "bus", "mod";
> +                       resets = <&ccu RST_BUS_THS>;
> +                       nvmem-cells = <&ths_calibration0>, <&ths_calibration1>;
> +                       nvmem-cell-names = "calibration",
> +                                    "calibration-second-part";
> +                       #thermal-sensor-cells = <0>;
> +               };
> +

The device nodes are sorted by base address, so the thermal sensors should
be much further up in this file.

>                 sid: efuse at 3006000 {
>                         compatible = "allwinner,sun55i-a523-sid",
>                                      "allwinner,sun50i-a64-sid";
>                         reg = <0x03006000 0x1000>;
>                         #address-cells = <1>;
>                         #size-cells = <1>;
> +
> +                       ths_calibration0: ths-calibration0 at 38 {
> +                               reg = <0x38 0x8>;
> +                       };
> +
> +                       ths_calibration1: ths-calibration1 at 44 {
> +                               reg = <0x44 0x8>;
> +                       };
>                 };
>
>                 gic: interrupt-controller at 3400000 {
> @@ -1087,4 +1130,115 @@ npu: npu at 7122000 {
>                         power-domains = <&ppu PD_NPU>;
>                 };
>         };
> +
> +       thermal-zones {
> +               cpu0_thermal: cpu0-thermal {
> +                       polling-delay-passive = <100>;
> +                       polling-delay = <1000>;
> +                       thermal-sensors = <&ths1 1>;
> +                       sustainable-power = <1200>;
> +
> +                       trips {
> +                               cpu0_threshold: cpu-trip-0 {
> +                                       temperature = <70000>;
> +                                       type = "passive";
> +                                       hysteresis = <0>;
> +                               };

Please have one empty line between nodes, per the DT coding style.
Same for the other two "trips" nodes.

> +                               cpu0_target: cpu-trip-1 {
> +                                       temperature = <90000>;
> +                                       type = "passive";
> +                                       hysteresis = <0>;
> +                               };
> +                               cpu0_critical: cpu-trip-2 {
> +                                       temperature = <110000>;s
> +                                       type = "critical";
> +                                       hysteresis = <0>;
> +                               };
> +                       };
> +
> +                       cooling-maps {
> +                               map0 {
> +                                       trip = <&cpu0_target>;
> +                                       cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +                                                        <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +                                                        <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +                                                        <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +                               };
> +                       };
> +               };
> +
> +               cpu4_thermal: cpu4-thermal {
> +                       polling-delay-passive = <100>;
> +                       polling-delay = <1000>;
> +                       thermal-sensors = <&ths1 0>;
> +                       sustainable-power = <1600>;
> +
> +                       trips {
> +                               cpu4_threshold: cpu-trip-0 {
> +                                       temperature = <70000>;
> +                                       type = "passive";
> +                                       hysteresis = <0>;
> +                               };
> +                               cpu4_target: cpu-trip-1 {
> +                                       temperature = <90000>;
> +                                       type = "passive";
> +                                       hysteresis = <0>;
> +                               };
> +                               cpu4_critical: cpu-trip-2 {
> +                                       temperature = <110000>;
> +                                       type = "critical";
> +                                       hysteresis = <0>;
> +                               };
> +                       };
> +
> +                       cooling-maps {
> +                               map0 {
> +                                       trip = <&cpu4_target>;
> +                                       cooling-device = <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +                                                        <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +                                                        <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +                                                        <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +                               };
> +                       };
> +               };
> +
> +               gpu-thermal {
> +                       polling-delay-passive = <100>;
> +                       polling-delay = <1000>;
> +                       thermal-sensors = <&ths1 2>;
> +                       sustainable-power = <2400>;
> +
> +                       gpu-trips {
> +                               gpu_temp_threshold: gpu-trip-0 {
> +                                       temperature = <60000>;
> +                                       type = "passive";
> +                                       hysteresis = <0>;
> +                               };
> +                               gpu_temp_target: gpu-trip-1 {
> +                                       temperature = <90000>;
> +                                       type = "passive";
> +                                       hysteresis = <0>;
> +                               };
> +                               gpu_temp_critical: gpu-trip-2 {
> +                                       temperature = <110000>;
> +                                       type = "critical";
> +                                       hysteresis = <0>;
> +                               };
> +                       };
> +               };
> +
> +               ddr-thermal {
> +                       polling-delay-passive = <0>;
> +                       polling-delay = <0>;
> +                       thermal-sensors = <&ths0>;
> +
> +                       trips {
> +                               ddr_temp_critical: ddr-trip-0 {
> +                                       temperature = <110000>;
> +                                       type = "critical";
> +                                       hysteresis = <0>;
> +                               };
> +                       };
> +               };
> +       };
>  };
> --
> 2.54.0
>



More information about the linux-arm-kernel mailing list