[PATCH 3/7] pinctrl: ingenic: Fix type in .pin_config_group_get() callback
Paul Cercueil
paul at crapouillou.net
Mon May 4 03:26:11 PDT 2026
Hi Geert,
Le jeudi 30 avril 2026 à 17:33 +0200, Geert Uytterhoeven a écrit :
> On 64-bit platforms, "unsigned long" is 64-bit. Hence checking if
> all
> "unsigned long" configuration values are equal should be done using
> an
> "unsigned long" temporary.
>
> While Ingenic is a 32-bit platform, it is still better to use the
> correct type, to serve as an example.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
Acked-by: Paul Cercueil <paul at crapouillou.net>
Cheers,
-Paul
> ---
> drivers/pinctrl/pinctrl-ingenic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index c7f14546de0528de..29d7f4e54bc7b126 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -4334,7 +4334,8 @@ static int ingenic_pinconf_group_get(struct
> pinctrl_dev *pctldev,
> unsigned int group, unsigned long *config)
> {
> const unsigned int *pins;
> - unsigned int i, npins, old = 0;
> + unsigned int i, npins;
> + unsigned long old = 0;
> int ret;
>
> ret = pinctrl_generic_get_group_pins(pctldev, group, &pins,
> &npins);
More information about the linux-arm-kernel
mailing list