[PATCH v3 1/4] dt-bindings: usb: dwc3-xilinx: Add MMI USB support on Versal Gen2 platform

[Krzysztof Kozlowski]

On Wed, Apr 29, 2026 at 11:00:47PM +0530, Radhey Shyam Pandey wrote:
>  additionalProperties: false
>  
>  examples:
> @@ -156,3 +193,30 @@ examples:
>              };
>          };
>      };
> +  - |
> +    #include <dt-bindings/power/xlnx-zynqmp-power.h>
> +    #include <dt-bindings/reset/xlnx-zynqmp-resets.h>
> +    #include <dt-bindings/phy/phy.h>
> +    usb {
> +        #address-cells = <1>;
> +        #size-cells = <1>;

Please follow DTS coding style.

> +        compatible = "xlnx,versal2-mmi-dwc3";

I really doubt that DWC3 block comes without addressing space
(registers), so either you just misrepresented things, like created a
fake block and syscon, or forgot to combine DWC3 with the wrapper.

And if you built with W=1 your DTS you would see errors. How do you see
it now? Where do you place it? Wrapper must be outside of soc, but DWC3
child must be inside. Did you read submitting patches and writing
bindings documents?

> +        clocks = <&zynqmp_clk 32>, <&zynqmp_clk 34>;
> +        clock-names = "bus_clk", "ref_clk";
> +        power-domains = <&zynqmp_firmware PD_USB_0>;
> +        resets = <&zynqmp_reset ZYNQMP_RESET_USB1_CORERESET>;
> +        reset-names = "usb_crst";
> +        phys = <&psgtr 2 PHY_TYPE_USB3 0 2>;
> +        phy-names = "usb3-phy";
> +        xlnx,usb-syscon = <&udh_slcr 0x005c 0x0070 0x00c4 0x00f8>;
> +        ranges;
> +
> +        usb at fe200000 {
> +            compatible = "snps,dwc3";
> +            reg = <0xfe200000 0x40000>;
> +            interrupt-names = "host", "otg";
> +            interrupts = <0 65 4>, <0 69 4>;

Why these are not proper defines?

> +            dr_mode = "host";
> +            dma-coherent;
> +        };
> +    };
> -- 
> 2.43.0
>