[RFT PATCH v3] ARM: omap1: enable real software node lookup of GPIOs on Nokia 770
Aaro Koskinen
aaro.koskinen at iki.fi
Fri Mar 27 11:41:44 PDT 2026
Hi,
On Fri, Mar 27, 2026 at 10:27:07AM -0700, Bartosz Golaszewski wrote:
> > Thanks. This makes sense. Both omap16xx_gpio_init() and
> > software_node_init() run as postcore_initcall() so if the order is not
> > right, it will fail.
> >
> > Cc'ing Andy who's a reviewer for software nodes. Andy: is there any
> > reason to run software_node_init() as a postcore initcall? It only
> > allocates the kset, can we move it to core_initcall() by any chance?
>
> In any case, Aaro: the following should theoretically fix it:
>
> diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
> index 51320837f3a9..5ba904f8a08a 100644
> --- a/drivers/base/swnode.c
> +++ b/drivers/base/swnode.c
> @@ -1134,7 +1134,7 @@ static int __init software_node_init(void)
> return -ENOMEM;
> return 0;
> }
> -postcore_initcall(software_node_init);
> +core_initcall(software_node_init);
>
> static void __exit software_node_exit(void)
> {
>
> If you could give it a spin and let me know if it does, it would be awesome.
Yeah it helps. With that change, both OSK and 770 work with your patch.
A.
More information about the linux-arm-kernel
mailing list