[PATCH] spi: pxa2xx: update outdated reference to pump_transfers()

Kexin Sun kexinsun at smail.nju.edu.cn
Sat Mar 21 03:59:45 PDT 2026


The function pump_transfers() was split into
pxa2xx_spi_transfer_one(), pxa2xx_spi_handle_err() and
pxa2xx_spi_set_cs() in commit d5898e19c0d7 ("spi: pxa2xx: Use
core message processing loop").  The comment in
pxa2xx_spi_dma_transfer_complete() still warns about concurrent
calls to pump_transfers(), but the actual operation protected by
dma_running is now spi_finalize_current_transfer().  Update the
reference.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun at smail.nju.edu.cn>
---
 drivers/spi/spi-pxa2xx-dma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-pxa2xx-dma.c b/drivers/spi/spi-pxa2xx-dma.c
index 08cb6e96ac94..c94d1d192e74 100644
--- a/drivers/spi/spi-pxa2xx-dma.c
+++ b/drivers/spi/spi-pxa2xx-dma.c
@@ -29,9 +29,9 @@ static void pxa2xx_spi_dma_transfer_complete(struct driver_data *drv_data,
 
 	/*
 	 * It is possible that one CPU is handling ROR interrupt and other
-	 * just gets DMA completion. Calling pump_transfers() twice for the
-	 * same transfer leads to problems thus we prevent concurrent calls
-	 * by using dma_running.
+	 * just gets DMA completion. Calling spi_finalize_current_transfer()
+	 * twice for the same transfer leads to problems thus we prevent
+	 * concurrent calls by using dma_running.
 	 */
 	if (atomic_dec_and_test(&drv_data->dma_running)) {
 		/*
-- 
2.25.1




More information about the linux-arm-kernel mailing list