[PATCH v12 5/7] qcom-tgu: Add support to configure next action
Jie Gan
jie.gan at oss.qualcomm.com
Wed Mar 18 06:47:46 PDT 2026
On 3/17/2026 11:26 AM, Songwei Chai wrote:
> Add "select" node for each step to determine if another step is taken,
> trigger(s) are generated, counters/timers incremented/decremented, etc.
>
Reviewed-by: Jie Gan <jie.gan at oss.qualcomm.com>
> Signed-off-by: Songwei Chai <songwei.chai at oss.qualcomm.com>
> ---
> .../ABI/testing/sysfs-bus-amba-devices-tgu | 7 +++
> drivers/hwtracing/qcom/tgu.c | 53 ++++++++++++++++++-
> drivers/hwtracing/qcom/tgu.h | 27 ++++++++++
> 3 files changed, 85 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu
> index 18930743c99f..d8431a82574a 100644
> --- a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu
> +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu
> @@ -21,3 +21,10 @@ KernelVersion 7.1
> Contact: Jinlong Mao <jinlong.mao at oss.qualcomm.com>, Songwei Chai <songwei.chai at oss.qualcomm.com>
> Description:
> (RW) Set/Get the decode mode with specific step for TGU.
> +
> +What: /sys/bus/amba/devices/<tgu-name>/step[0:7]_condition_select/reg[0:3]
> +Date: March 2026
> +KernelVersion 7.1
> +Contact: Jinlong Mao <jinlong.mao at oss.qualcomm.com>, Songwei Chai <songwei.chai at oss.qualcomm.com>
> +Description:
> + (RW) Set/Get the next action with specific step for TGU.
> diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c
> index 85fe1140eab5..1d996b9e303a 100644
> --- a/drivers/hwtracing/qcom/tgu.c
> +++ b/drivers/hwtracing/qcom/tgu.c
> @@ -29,6 +29,9 @@ static int calculate_array_location(struct tgu_drvdata *drvdata,
> case TGU_CONDITION_DECODE:
> return step_index * (drvdata->num_condition_decode) +
> reg_index;
> + case TGU_CONDITION_SELECT:
> + return step_index * (drvdata->num_condition_select) +
> + reg_index;
> default:
> break;
> }
> @@ -71,6 +74,9 @@ static ssize_t tgu_dataset_show(struct device *dev,
> case TGU_CONDITION_DECODE:
> return sysfs_emit(buf, "0x%x\n",
> drvdata->value_table->condition_decode[index]);
> + case TGU_CONDITION_SELECT:
> + return sysfs_emit(buf, "0x%x\n",
> + drvdata->value_table->condition_select[index]);
> default:
> break;
> }
> @@ -112,6 +118,10 @@ static ssize_t tgu_dataset_store(struct device *dev,
> tgu_drvdata->value_table->condition_decode[index] = val;
> ret = size;
> break;
> + case TGU_CONDITION_SELECT:
> + tgu_drvdata->value_table->condition_select[index] = val;
> + ret = size;
> + break;
> default:
> ret = -EINVAL;
> break;
> @@ -146,6 +156,13 @@ static umode_t tgu_node_visible(struct kobject *kobject,
> if (tgu_attr->reg_num < drvdata->num_condition_decode)
> return attr->mode;
> break;
> + case TGU_CONDITION_SELECT:
> + /* 'default' register is at the end of 'select' region */
> + if (tgu_attr->reg_num == drvdata->num_condition_select - 1)
> + attr->name = "default";
> + if (tgu_attr->reg_num < drvdata->num_condition_select)
> + return attr->mode;
> + break;
> default:
> break;
> }
> @@ -184,6 +201,18 @@ static ssize_t tgu_write_all_hw_regs(struct tgu_drvdata *drvdata)
> drvdata->base + CONDITION_DECODE_STEP(i, j));
> }
> }
> +
> + for (i = 0; i < drvdata->num_step; i++) {
> + for (j = 0; j < drvdata->num_condition_select; j++) {
> + index = check_array_location(drvdata, i,
> + TGU_CONDITION_SELECT, j);
> + if (index == -EINVAL)
> + goto exit;
> +
> + writel(drvdata->value_table->condition_select[index],
> + drvdata->base + CONDITION_SELECT_STEP(i, j));
> + }
> + }
> /* Enable TGU to program the triggers */
> writel(1, drvdata->base + TGU_CONTROL);
> exit:
> @@ -223,6 +252,8 @@ static void tgu_set_conditions(struct tgu_drvdata *drvdata)
>
> devid = readl(drvdata->base + TGU_DEVID);
> drvdata->num_condition_decode = TGU_DEVID_CONDITIONS(devid);
> + /* select region has an additional 'default' register */
> + drvdata->num_condition_select = TGU_DEVID_CONDITIONS(devid) + 1;
> }
>
> static int tgu_enable(struct device *dev)
> @@ -356,6 +387,14 @@ static const struct attribute_group *tgu_attr_groups[] = {
> CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(5),
> CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(6),
> CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(7),
> + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(0),
> + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(1),
> + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(2),
> + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(3),
> + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(4),
> + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(5),
> + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(6),
> + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(7),
> NULL,
> };
>
> @@ -363,8 +402,8 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id)
> {
> struct device *dev = &adev->dev;
> struct tgu_drvdata *drvdata;
> - unsigned int *priority, *condition;
> - size_t priority_size, condition_size;
> + unsigned int *priority, *condition, *select;
> + size_t priority_size, condition_size, select_size;
> int ret;
>
> drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
> @@ -415,6 +454,16 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id)
>
> drvdata->value_table->condition_decode = condition;
>
> + select_size = drvdata->num_condition_select * drvdata->num_step;
> +
> + select = devm_kcalloc(dev, select_size,
> + sizeof(*(drvdata->value_table->condition_select)),
> + GFP_KERNEL);
> + if (!select)
> + return -ENOMEM;
> +
> + drvdata->value_table->condition_select = select;
> +
> drvdata->enabled = false;
>
> pm_runtime_put(&adev->dev);
> diff --git a/drivers/hwtracing/qcom/tgu.h b/drivers/hwtracing/qcom/tgu.h
> index 987ea07bd618..ac46a2875209 100644
> --- a/drivers/hwtracing/qcom/tgu.h
> +++ b/drivers/hwtracing/qcom/tgu.h
> @@ -52,6 +52,7 @@
> #define STEP_OFFSET 0x1D8
> #define PRIORITY_START_OFFSET 0x0074
> #define CONDITION_DECODE_OFFSET 0x0050
> +#define CONDITION_SELECT_OFFSET 0x0060
> #define PRIORITY_OFFSET 0x60
> #define REG_OFFSET 0x4
>
> @@ -63,6 +64,9 @@
> #define CONDITION_DECODE_STEP(step, decode) \
> (CONDITION_DECODE_OFFSET + REG_OFFSET * decode + STEP_OFFSET * step)
>
> +#define CONDITION_SELECT_STEP(step, select) \
> + (CONDITION_SELECT_OFFSET + REG_OFFSET * select + STEP_OFFSET * step)
> +
> #define tgu_dataset_rw(name, step_index, type, reg_num) \
> (&((struct tgu_attribute[]){ { \
> __ATTR(name, 0644, tgu_dataset_show, tgu_dataset_store), \
> @@ -76,6 +80,8 @@
> reg_num)
> #define STEP_DECODE(step_index, reg_num) \
> tgu_dataset_rw(reg##reg_num, step_index, TGU_CONDITION_DECODE, reg_num)
> +#define STEP_SELECT(step_index, reg_num) \
> + tgu_dataset_rw(reg##reg_num, step_index, TGU_CONDITION_SELECT, reg_num)
>
> #define STEP_PRIORITY_LIST(step_index, priority) \
> {STEP_PRIORITY(step_index, 0, priority), \
> @@ -107,6 +113,15 @@
> NULL \
> }
>
> +#define STEP_SELECT_LIST(n) \
> + {STEP_SELECT(n, 0), \
> + STEP_SELECT(n, 1), \
> + STEP_SELECT(n, 2), \
> + STEP_SELECT(n, 3), \
> + STEP_SELECT(n, 4), \
> + NULL \
> + }
> +
> #define PRIORITY_ATTRIBUTE_GROUP_INIT(step, priority)\
> (&(const struct attribute_group){\
> .attrs = (struct attribute*[])STEP_PRIORITY_LIST(step, priority),\
> @@ -121,12 +136,21 @@
> .name = "step" #step "_condition_decode" \
> })
>
> +#define CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(step)\
> + (&(const struct attribute_group){\
> + .attrs = (struct attribute*[])STEP_SELECT_LIST(step),\
> + .is_visible = tgu_node_visible,\
> + .name = "step" #step "_condition_select" \
> + })
> +
> +
> enum operation_index {
> TGU_PRIORITY0,
> TGU_PRIORITY1,
> TGU_PRIORITY2,
> TGU_PRIORITY3,
> TGU_CONDITION_DECODE,
> + TGU_CONDITION_SELECT,
> };
>
> /* Maximum priority that TGU supports */
> @@ -142,6 +166,7 @@ struct tgu_attribute {
> struct value_table {
> unsigned int *priority;
> unsigned int *condition_decode;
> + unsigned int *condition_select;
> };
>
> static inline void TGU_LOCK(void __iomem *addr)
> @@ -172,6 +197,7 @@ static inline void TGU_UNLOCK(void __iomem *addr)
> * @num_reg: Maximum number of registers
> * @num_step: Maximum step size
> * @num_condition_decode: Maximum number of condition_decode
> + * @num_condition_select: Maximum number of condition_select
> *
> * This structure defines the data associated with a TGU device,
> * including its base address, device pointers, clock, spinlock for
> @@ -187,6 +213,7 @@ struct tgu_drvdata {
> int num_reg;
> int num_step;
> int num_condition_decode;
> + int num_condition_select;
> };
>
> #endif
More information about the linux-arm-kernel
mailing list