[PATCH] firmware: arm_scmi: Support loop control in quirk code snippets
Cristian Marussi
cristian.marussi at arm.com
Mon Mar 16 09:53:19 PDT 2026
On Mon, Mar 16, 2026 at 04:34:40PM +0100, Geert Uytterhoeven wrote:
> Each SCMI firmware quirk contains a code snippet, which handles the
> quirk, and has full access to the surrounding context. When this
> context is (part of) a loop body, the code snippet may want to use loop
> control statements like "break" and "continue". Unfortunately the
> SCMI_QUIRK() macro implementation contains a dummy loop, taking
> precedence over any outer loops. Hence quirk code cannot use loop
> control statements, but has to resort to polluting the surrounding
> context with a label, and use goto.
Hi,
indeed...good catch, thanks for this.
I think, no need to backport as Fixes since existing quirks are NOT
impacted.
LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi at arm.com>
Thanks,
Cristian
More information about the linux-arm-kernel
mailing list