[PATCH v3 5/5] dt-bindings: usb: atmel,at91sam9rl-udc: convert to DT schema
Krzysztof Kozlowski
krzk at kernel.org
Sun Mar 8 01:29:40 PST 2026
On Sat, Mar 07, 2026 at 09:16:22AM +0000, Charan Pedumuru wrote:
> +
> + reg:
> + maxItems: 2
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 2
Drop
> + maxItems: 2
> +
> + clock-names:
> + minItems: 2
> + maxItems: 2
> + items:
> + enum: [pclk, hclk]
No, list the items instead. Why is this flexible? Nothing in commit msg
explains that.
> +
> + atmel,vbus-gpio:
> + description: GPIO used to detect the presence of VBUS, indicating that
> + the USB cable is connected.
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/at91.h>
> + #include <dt-bindings/gpio/gpio.h>
> + gadget at fff78000 {
> + compatible = "atmel,at91sam9g45-udc";
> + reg = <0x00600000 0x80000
> + 0xfff78000 0x400>;
> + interrupts = <27 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&pmc PMC_TYPE_PERIPHERAL 27>, <&pmc PMC_TYPE_CORE PMC_UTMI>;
> + clock-names = "pclk", "hclk";
> + atmel,vbus-gpio = <&pioC 15 GPIO_ACTIVE_HIGH>;
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> deleted file mode 100644
> index 12183ef47ee4..000000000000
> --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
> +++ /dev/null
> @@ -1,125 +0,0 @@
> -Atmel SOC USB controllers
> -
> -OHCI
> -
> -Required properties:
> - - compatible: Should be "atmel,at91rm9200-ohci" for USB controllers
Why do you remove OHCI here? There is no conversion of this compatible.
Don't combine multiple different changes in one commit.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list