[PATCH v2 01/11] arm64: Skip update of an idreg field affected by an override

Marc Zyngier maz at kernel.org
Mon Mar 2 05:47:04 PST 2026


On Mon, 02 Mar 2026 13:14:15 +0000,
Fuad Tabba <tabba at google.com> wrote:
> 
> On Mon, 2 Mar 2026 at 13:05, Fuad Tabba <tabba at google.com> wrote:
> >
> > Hi Marc,
> >
> > On Mon, 2 Mar 2026 at 11:57, Marc Zyngier <maz at kernel.org> wrote:
> > >
> > > When computing the new value od an idreg that contains a field
> >
> > nit: od->of
> >
> > > affected by an override, do not update that particular field.
> > >
> > > The value computed at init-time must be kept as-is, as that's
> > > what the user has asked for, for better or worse.
> > >
> > > Signed-off-by: Marc Zyngier <maz at kernel.org>
> 
> Another nit, should you add a fixes tag, since this flaw is tired to
> the original override facility? i.e.,
> 8f266a5d878a ("arm64: cpufeature: Add global feature override facility").

Yup, good point.

>
> > Reviewed-by: Fuad Tabba <tabba at google.com>

Thanks!

	M.

-- 
Without deviation from the norm, progress is not possible.



More information about the linux-arm-kernel mailing list