[PATCH 2/4] media: mc: use fwnode_graph_for_each_endpoint_scoped() to simpilfy code

G.N. Zhou guoniu.zhou at nxp.com
Tue Jun 23 20:15:37 PDT 2026


Hi Frank,

> -----Original Message-----
> From: Frank Li (OSS) <frank.li at oss.nxp.com>
> Sent: Monday, June 22, 2026 10:30 PM
> To: Andy Shevchenko <andriy.shevchenko at linux.intel.com>; Daniel Scally
> <djrscally at gmail.com>; Heikki Krogerus <heikki.krogerus at linux.intel.com>;
> Sakari Ailus <sakari.ailus at linux.intel.com>; Greg Kroah-Hartman
> <gregkh at linuxfoundation.org>; Rafael J. Wysocki <rafael at kernel.org>; Danilo
> Krummrich <dakr at kernel.org>; Mauro Carvalho Chehab
> <mchehab at kernel.org>; Dafna Hirschfeld <dafna at fastmail.com>; Laurent
> Pinchart <laurent.pinchart at ideasonboard.com>; Heiko Stuebner
> <heiko at sntech.de>; Bryan O'Donoghue <bryan.odonoghue at linaro.org>;
> Vladimir Zapolskiy <vladimir.zapolskiy at linaro.org>; Loic Poulain
> <loic.poulain at oss.qualcomm.com>
> Cc: driver-core at lists.linux.dev; linux-acpi at vger.kernel.org; linux-
> kernel at vger.kernel.org; linux-media at vger.kernel.org; linux-
> rockchip at lists.infradead.org; linux-arm-kernel at lists.infradead.org; linux-arm-
> msm at vger.kernel.org; imx at lists.linux.dev; G.N. Zhou
> <guoniu.zhou at nxp.com>; Frank Li <frank.li at nxp.com>
> Subject: [PATCH 2/4] media: mc: use
> fwnode_graph_for_each_endpoint_scoped() to simpilfy code
> 
> From: Frank Li <Frank.Li at nxp.com>
> 
> Use cleanup helper fwnode_graph_for_each_endpoint_scoped() to simpilfy

s/simpifly/simplify/ both in message title and body.

With this addressed:
Reviewed-by: Guoniu Zhou <guoniu.zhou at oss.nxp.com>

> code.
> 
> Signed-off-by: Frank Li <Frank.Li at nxp.com>
> ---
>  drivers/media/v4l2-core/v4l2-mc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-
> mc.c
> index 937d358697e19..5d7fcd67dc42e 100644
> --- a/drivers/media/v4l2-core/v4l2-mc.c
> +++ b/drivers/media/v4l2-core/v4l2-mc.c
> @@ -324,12 +324,10 @@
> EXPORT_SYMBOL_GPL(v4l_vb2q_enable_media_source);
>  int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd,
>  				    struct media_pad *sink, u32 flags)  {
> -	struct fwnode_handle *endpoint;
> -
>  	if (!(sink->flags & MEDIA_PAD_FL_SINK))
>  		return -EINVAL;
> 
> -	fwnode_graph_for_each_endpoint(src_sd->fwnode, endpoint) {
> +	fwnode_graph_for_each_endpoint_scoped(src_sd->fwnode, endpoint)
> {
>  		struct fwnode_handle *remote_ep;
>  		int src_idx, sink_idx, ret;
>  		struct media_pad *src;
> @@ -397,7 +395,6 @@ int v4l2_create_fwnode_links_to_pad(struct
> v4l2_subdev *src_sd,
>  				src_sd->entity.name, src_idx,
>  				sink->entity->name, sink_idx, ret);
> 
> -			fwnode_handle_put(endpoint);
>  			return ret;
>  		}
>  	}
> 
> --
> 2.43.0




More information about the linux-arm-kernel mailing list