[PATCH v7 4/4] arm64: tegra: Reorder reg and reg-names to match bindings

[Manivannan Sadhasivam]

On Wed, Jun 17, 2026 at 06:01:31PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding at nvidia.com>
> 
> The ECAM region cannot be the first entry in the "reg" property, because
> in that case the unit-address wouldn't match the first entry. The order
> of the nodes can also not be changed to match the ECAM entry because the
> ECAM region is global and outside of any of the control busses.
> 
> Signed-off-by: Thierry Reding <treding at nvidia.com>

Acked-by: Manivannan Sadhasivam <mani at kernel.org>

- Mani

> ---
> Changes in v5:
> - rebase onto v7.1-rc1
> 
> Changes in v4:
> - revert ECAM "reg" entry order
> 
> Changes in v2:
> - order ECAM "reg" entry before others
> ---
>  arch/arm64/boot/dts/nvidia/tegra264.dtsi | 48 ++++++++++++++++----------------
>  1 file changed, 24 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra264.dtsi b/arch/arm64/boot/dts/nvidia/tegra264.dtsi
> index 8f4350c7793b..4c701abd25a8 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra264.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra264.dtsi
> @@ -3513,11 +3513,11 @@ cmdqv4: cmdqv at b200000 {
>  
>  		pci at c000000 {
>  			compatible = "nvidia,tegra264-pcie";
> -			reg = <0xd0 0xb0000000 0x0 0x10000000>,
> -			      <0x00 0x0c000000 0x0 0x00004000>,
> +			reg = <0x00 0x0c000000 0x0 0x00004000>,
>  			      <0x00 0x0c004000 0x0 0x00001000>,
> -			      <0x00 0x0c005000 0x0 0x00001000>;
> -			reg-names = "ecam", "xal", "xtl", "xtl-pri";
> +			      <0x00 0x0c005000 0x0 0x00001000>,
> +			      <0xd0 0xb0000000 0x0 0x10000000>;
> +			reg-names = "xal", "xtl", "xtl-pri", "ecam";
>  			#address-cells = <3>;
>  			#size-cells = <2>;
>  			device_type = "pci";
> @@ -3893,12 +3893,12 @@ gpio_uphy: gpio at 8300000 {
>  
>  		pci at 8400000 {
>  			compatible = "nvidia,tegra264-pcie";
> -			reg = <0xa8 0xb0000000 0x0 0x10000000>,
> -			      <0x00 0x08400000 0x0 0x00004000>,
> +			reg = <0x00 0x08400000 0x0 0x00004000>,
>  			      <0x00 0x08404000 0x0 0x00001000>,
>  			      <0x00 0x08405000 0x0 0x00001000>,
> -			      <0x00 0x08410000 0x0 0x00010000>;
> -			reg-names = "ecam", "xal", "xtl", "xtl-pri", "xpl";
> +			      <0x00 0x08410000 0x0 0x00010000>,
> +			      <0xa8 0xb0000000 0x0 0x10000000>;
> +			reg-names = "xal", "xtl", "xtl-pri", "xpl", "ecam";
>  			#address-cells = <3>;
>  			#size-cells = <2>;
>  			device_type = "pci";
> @@ -3925,12 +3925,12 @@ pci at 8400000 {
>  
>  		pci at 8420000 {
>  			compatible = "nvidia,tegra264-pcie";
> -			reg = <0xb0 0xb0000000 0x0 0x10000000>,
> -			      <0x00 0x08420000 0x0 0x00004000>,
> +			reg = <0x00 0x08420000 0x0 0x00004000>,
>  			      <0x00 0x08424000 0x0 0x00001000>,
>  			      <0x00 0x08425000 0x0 0x00001000>,
> -			      <0x00 0x08430000 0x0 0x00010000>;
> -			reg-names = "ecam", "xal", "xtl", "xtl-pri", "xpl";
> +			      <0x00 0x08430000 0x0 0x00010000>,
> +			      <0xb0 0xb0000000 0x0 0x10000000>;
> +			reg-names = "xal", "xtl", "xtl-pri", "xpl", "ecam";
>  			#address-cells = <3>;
>  			#size-cells = <2>;
>  			device_type = "pci";
> @@ -3957,12 +3957,12 @@ pci at 8420000 {
>  
>  		pci at 8440000 {
>  			compatible = "nvidia,tegra264-pcie";
> -			reg = <0xb8 0xb0000000 0x0 0x10000000>,
> -			      <0x00 0x08440000 0x0 0x00004000>,
> +			reg = <0x00 0x08440000 0x0 0x00004000>,
>  			      <0x00 0x08444000 0x0 0x00001000>,
>  			      <0x00 0x08445000 0x0 0x00001000>,
> -			      <0x00 0x08450000 0x0 0x00010000>;
> -			reg-names = "ecam", "xal", "xtl", "xtl-pri", "xpl";
> +			      <0x00 0x08450000 0x0 0x00010000>,
> +			      <0xb8 0xb0000000 0x0 0x10000000>;
> +			reg-names = "xal", "xtl", "xtl-pri", "xpl", "ecam";
>  			#address-cells = <3>;
>  			#size-cells = <2>;
>  			device_type = "pci";
> @@ -3989,12 +3989,12 @@ pci at 8440000 {
>  
>  		pci at 8460000 {
>  			compatible = "nvidia,tegra264-pcie";
> -			reg = <0xc0 0xb0000000 0x0 0x10000000>,
> -			      <0x00 0x08460000 0x0 0x00004000>,
> +			reg = <0x00 0x08460000 0x0 0x00004000>,
>  			      <0x00 0x08464000 0x0 0x00001000>,
>  			      <0x00 0x08465000 0x0 0x00001000>,
> -			      <0x00 0x08470000 0x0 0x00010000>;
> -			reg-names = "ecam", "xal", "xtl", "xtl-pri", "xpl";
> +			      <0x00 0x08470000 0x0 0x00010000>,
> +			      <0xc0 0xb0000000 0x0 0x10000000>;
> +			reg-names = "xal", "xtl", "xtl-pri", "xpl", "ecam";
>  			#address-cells = <3>;
>  			#size-cells = <2>;
>  			device_type = "pci";
> @@ -4021,12 +4021,12 @@ pci at 8460000 {
>  
>  		pci at 8480000 {
>  			compatible = "nvidia,tegra264-pcie";
> -			reg = <0xc8 0xb0000000 0x0 0x10000000>,
> -			      <0x00 0x08480000 0x0 0x00004000>,
> +			reg = <0x00 0x08480000 0x0 0x00004000>,
>  			      <0x00 0x08484000 0x0 0x00001000>,
>  			      <0x00 0x08485000 0x0 0x00001000>,
> -			      <0x00 0x08490000 0x0 0x00010000>;
> -			reg-names = "ecam", "xal", "xtl", "xtl-pri", "xpl";
> +			      <0x00 0x08490000 0x0 0x00010000>,
> +			      <0xc8 0xb0000000 0x0 0x10000000>;
> +			reg-names = "xal", "xtl", "xtl-pri", "xpl", "ecam";
>  			#address-cells = <3>;
>  			#size-cells = <2>;
>  			device_type = "pci";
> 
> -- 
> 2.54.0
> 

-- 
மணிவண்ணன் சதாசிவம்