[PATCH 5/6] irqchip/gic-v3-its: fix typo in comments
Kemeng Shi
shikemeng at huaweicloud.com
Mon Jun 15 18:49:15 PDT 2026
在 2026/6/15 17:03:47, Marc Zyngier 写道:
> On Mon, 15 Jun 2026 04:29:09 +0100,
> Kemeng Shi <shikemeng at huaweicloud.com> wrote:
>>
>> 1. "If it some" -> "If some"
>> 2. "by table by reading" -> by reading"
>>
>> Signed-off-by: Kemeng Shi <shikemeng at huaweicloud.com>
>> ---
>> drivers/irqchip/irq-gic-v3-its.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
>> index becd8dd51720..fc32a1709f76 100644
>> --- a/drivers/irqchip/irq-gic-v3-its.c
>> +++ b/drivers/irqchip/irq-gic-v3-its.c
>> @@ -163,7 +163,7 @@ struct event_lpi_map {
>>
>> /*
>> * The ITS view of a device - belongs to an ITS, owns an interrupt
>> - * translation table, and a list of interrupts. If it some of its
>> + * translation table, and a list of interrupts. If some of its
>> * LPIs are injected into a guest (GICv4), the event_map.vm field
>> * indicates which one.
>> */
>> @@ -2501,7 +2501,7 @@ static bool its_parse_indirect_baser(struct its_node *its,
>> if ((esz << ids) > (psz * 2)) {
>> /*
>> * Find out whether hw supports a single or two-level table by
>> - * table by reading bit at offset '62' after writing '1' to it.
>> + * reading bit at offset '62' after writing '1' to it.
>> */
>
> If you are going to fix that comment, fix it for good by replacing the
> reference to a bit number with its actual name, making it valuable for
> everyone.
Will improve with this in next version.
Thanks,
Kemeng>
> M.
>
>> its_write_baser(its, baser, val | GITS_BASER_INDIRECT);
>> indirect = !!(baser->val & GITS_BASER_INDIRECT);
>> --
>> 2.36.1
>>
>>
>
More information about the linux-arm-kernel
mailing list