[PATCH v5 2/3] pwm: rp1: Add RP1 PWM controller driver

Julian Braha julianbraha at gmail.com
Mon Jun 15 03:29:11 PDT 2026


Hi Uwe,

On 6/15/26 07:37, Uwe Kleine-König wrote:
> IMHO selecting REGMAP_MMIO explicitly here is fine because at least to
> me it's not obvious that MFD_SYSCON enforces REGMAP_MMIO.

I think it's better to use comments to document non-obvious behavior,
rather than dead code.
E.g.:
'select MFD_SYSCON # selects REGMAP_MMIO'

But I guess this is not really worth bikeshedding over.

- Julian Braha



More information about the linux-arm-kernel mailing list