[PATCH v2 6/7] arm64: dts: qcom: shikra-cqm-cqs-evk-imx577-camera: Add DT overlay
Nihal Kumar Gupta
nihal.gupta at oss.qualcomm.com
Fri Jun 12 21:46:49 PDT 2026
On 12-06-2026 13:40, Vladimir Zapolskiy wrote:
>> + imx577_ep1: endpoint {
>> + link-frequencies = /bits/ 64 <600000000>;
>> + data-lanes = <0 1 2 3>;
>
> The numeration of data-lanes shall be started from 1, this has to be fixed.
>
Thanks for pointing it.
Will fix in v3. On MIPI D-PHY, lane 0 is the clock lane, so data lanes
must start from 1 as per video-interfaces.yaml binding spec.
>> + remote-endpoint = <&csiphy1_ep>;
>> + };
>> + };
>> + };
>> +&tlmm {
>> + cam1_reset_default: cam1-reset-default-state {
>> + pins = "gpio33";
>> + function = "gpio";
>> + drive-strength = <2>;
>> + bias-disable;
>> + };
>> +};
>
> Since it's a mezzanine specific pinctl assignment, it shall go to the
> correspondent .dtso file.
>
> It's a concidence that one .dtso file is good enough for describing the
> mezzanine for two diffferent boards, but let's exploit it by keeping one
> dt overlay file as it is now.
Agreed, will move it to the .dtso in v3.
This also eliminates the identical cam1_reset_default block duplicated across
CQM and CQS board files.
Will incorporate this for the IQS dtso file.
--
Regards,
Nihal Kumar Gupta
More information about the linux-arm-kernel
mailing list