[PATCH] crypto: atmel-ecc - remove stale comments in atmel_ecc_remove

Herbert Xu herbert at gondor.apana.org.au
Wed Jun 10 22:29:52 PDT 2026


On Tue, Jun 02, 2026 at 06:52:49PM +0200, Thorsten Blum wrote:
> atmel_ecc_remove() no longer returns -EBUSY since commit 7df7563b16aa
> ("crypto: atmel-ecc - Remove duplicated error reporting in .remove()")
> and is a void function since commit ed5c2f5fd10d ("i2c: Make remove
> callback return void").
> 
> Remove and update the outdated comments.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum at linux.dev>
> ---
>  drivers/crypto/atmel-ecc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index 9c380351d2f9..e6068dc0a0c1 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -347,13 +347,11 @@ static void atmel_ecc_remove(struct i2c_client *client)
>  {
>  	struct atmel_i2c_client_priv *i2c_priv = i2c_get_clientdata(client);
>  
> -	/* Return EBUSY if i2c client already allocated. */
>  	if (atomic_read(&i2c_priv->tfm_count)) {
>  		/*
>  		 * After we return here, the memory backing the device is freed.
> -		 * That happens no matter what the return value of this function
> -		 * is because in the Linux device model there is no error
> -		 * handling for unbinding a driver.
> +		 * That happens because in the Linux device model there is no
> +		 * error handling for unbinding a driver.
>  		 * If there is still some action pending, it probably involves
>  		 * accessing the freed memory.
>  		 */

Please fix this properly rather than fiddling with the comments.

Drivers should always fail gracefully if the hardware disappears.

Thanks,
-- 
Email: Herbert Xu <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



More information about the linux-arm-kernel mailing list