[PATCH 1/2] ufs: core: Add get_hba_nortt callback for vendor-specific RTT capability
Bart Van Assche
bvanassche at acm.org
Wed Jun 10 09:46:09 PDT 2026
On 6/9/26 3:38 AM, ed.tsai at mediatek.com wrote:
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
> index cfbc75d8df83..13d0d7798294 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -370,7 +370,6 @@ struct ufshcd_tx_eq_params {
> /**
> * struct ufs_hba_variant_ops - variant specific callbacks
> * @name: variant name
> - * @max_num_rtt: maximum RTT supported by the host
> * @init: called when the driver is initialized
> * @exit: called to cleanup everything done in init
> * @set_dma_mask: For setting another DMA mask than indicated by the 64AS
> @@ -415,10 +414,11 @@ struct ufshcd_tx_eq_params {
> * @get_rx_fom: called to get Figure of Merit (FOM) value.
> * @tx_eqtr_notify: called before and after TX Equalization Training procedure
> * to allow platform vendor specific configs to take place.
> + * @get_hba_nortt: called to get maximum number of outstanding RTTs supported by
> + * the controller.
> */
> struct ufs_hba_variant_ops {
> const char *name;
> - int max_num_rtt;
> int (*init)(struct ufs_hba *);
> void (*exit)(struct ufs_hba *);
> u32 (*get_ufs_hci_version)(struct ufs_hba *);
> @@ -477,6 +477,7 @@ struct ufs_hba_variant_ops {
> int (*tx_eqtr_notify)(struct ufs_hba *hba,
> enum ufs_notify_change_status status,
> struct ufs_pa_layer_attr *pwr_mode);
> + int (*get_hba_nortt)(struct ufs_hba *hba);
> };
A patch series should be bisectable. Removing max_num_rtt from struct
ufs_hba_variant_ops before the code is removed from the MediaTek driver
that sets that variable introduces a build break. Please keep
'max_num_rtt' in this patch and add a third patch to this series that
removes 'max_num_rtt'.
Thanks,
Bart.
More information about the linux-arm-kernel
mailing list