[PATCHv2 0/3] watchdog: sama5d4: fix IRQ and timeout bugs, use platform_get_irq_optional
Nicolas Ferre
nicolas.ferre at microchip.com
Mon Jun 8 13:38:46 PDT 2026
On 08/06/2026 at 13:09, Rosen Penev wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> This series fixes three issues in the sama5d4 watchdog driver:
>
> Patch 1: Return IRQ_NONE when the status register indicates no watchdog
> interrupt is pending, and pass the configured timeout (not the hardcoded
> default) to sama5d4_wdt_init().
>
> Patch 2: Replace irq_of_parse_and_map() with platform_get_irq_optional()
> for simpler error handling and EPROBE_DEFER support.
>
> Patch 3: Move platform_set_drvdata() before devm_request_irq() to prevent
> a NULL pointer dereference in the interrupt handler if the shared System
> IRQ fires immediately after registration.
>
> v2: address sashiko review
Rosen,
I'd like to hear how these issues where found and how the patches were
tested.
Best regards,
Nicolas
> Rosen Penev (3):
> watchdog: sama5d4: fix shared IRQ and hardcoded timeout issues
> watchdog: sama5d4: use platform_get_irq_optional()
> watchdog: sama5d4: fix NULL deref in irq handler
>
> drivers/watchdog/sama5d4_wdt.c | 32 +++++++++++++++++---------------
> 1 file changed, 17 insertions(+), 15 deletions(-)
>
> --
> 2.54.0
>
More information about the linux-arm-kernel
mailing list