[PATCH v3] net: stmmac: fix fatal bus error on resume by reinitializing RX buffers
Jakub Raczynski
j.raczynski at samsung.com
Mon Jun 8 02:41:25 PDT 2026
On Thu, Jun 04, 2026 at 10:45:54PM +0800, Ding Hui wrote:
> From: Ding Hui <dinghui at lixiang.com>
> + for (queue = 0; queue < priv->plat->rx_queues_to_use; queue++) {
> + ret = stmmac_reinit_rx_descriptors(priv, &priv->dma_conf,
> + queue);
> + if (ret) {
> + netdev_err(priv->dev,
> + "%s: rx desc reinit failed on queue %u\n",
> + __func__, queue);
> + mutex_unlock(&priv->lock);
> + rtnl_unlock();
> + return ret;
> + }
> + }
This is not directly related to the patch, but rather stmmac_resume() itself,
but doesn't this return and hw_setup one leave bunch of descriptor memory
hanging and effectively leaked?
> +
> ret = stmmac_hw_setup(ndev);
> if (ret < 0) {
> netdev_err(priv->dev, "%s: Hw setup failed\n", __func__);
> --
Other than that, I don't see any obvious issues.
Reviewed-by: Jakub Raczynski <j.raczynski at samsung.com>
More information about the linux-arm-kernel
mailing list