[PATCH 01/11] net: wwan: t9xx: Add PCIe core
Jagielski, Jedrzej
jedrzej.jagielski at intel.com
Mon Jun 8 00:40:51 PDT 2026
From: Wu. JackBB (GSM) <JackBB_Wu at compal.com>
Sent: Thursday, June 4, 2026 8:43 AM
>> Sent: Friday, May 29, 2026 12:32 PM
>>
>> > +
>>
>> please also take a look on sashiko notes, there is some number of them
>
>Hi Jagielski,
>
> Thank you for your review. We have fixed some issues and are still discussing others with MediaTek. All of them will be addressed in V2.
>
> Regarding sashiko notes, how should I handle them if discussion is needed? I cannot find sashiko's email address, and its website does not have a reply option.
>
I guess discussion is needed when any of the reviewers directly refers
to any of the notes posted by sashiko.
If any of the notes was not directly pointed out by anybody please just
check which of sashiko notes are valid and fix them respectively
if needed.
>For example:
> https://sashiko.dev/#/patchset/20260529-t9xx_driver_v1-v1-0-bdbfe2c01e57%40compal.com?part=2
>
> Q1:
> The commit message mentions implementing TX and RX services, but the patch primarily adds empty structures and boilerplate code. Is the patch missing the actual TX/RX implementation described here?
>
> Reply:
> We plan to update the commit message. Would the following be acceptable?
I believe if you want to check if sashiko has no any longer problems with it you
need to send v2 and check that way, unless im not aware of something
>
> Add the control plane transaction layer framework for the t9xx
> WWAN driver, including configuration options, device structure
> definitions, and initialization/cleanup functions.
>
> The actual TX/RX service implementations that use this framework
> are introduced in subsequent patches.
>
>
>Thanks.
More information about the linux-arm-kernel
mailing list