[PATCH 1/2] perf hisi-ptt: Fix spelling and abbreviation errors
James Clark
james.clark at linaro.org
Wed Jul 29 03:17:14 PDT 2026
On 29/07/2026 7:02 am, Sizhe Liu wrote:
> Fix spelling and abbreviation errors in the PTT packet decoder:
> - HISI_PTT_FIELD_LENTH -> HISI_PTT_FIELD_LENGTH
> - hisi_ptt_8dw_kpt_desc -> hisi_ptt_8dw_pkt_desc
> - hisi_ptt_4dw_kpt_desc -> hisi_ptt_4dw_pkt_desc
>
> Cc: stable at vger.kernel.org
> Fixes: 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing HiSilicon PCIe Trace packet")
Probably doesn't need a fixes tag, but:
Reviewed-by: James Clark <james.clark at linaro.org>
> Signed-off-by: Sizhe Liu <liusizhe5 at huawei.com>
> ---
> .../hisi-ptt-decoder/hisi-ptt-pkt-decoder.c | 20 +++++++++----------
> .../hisi-ptt-decoder/hisi-ptt-pkt-decoder.h | 2 +-
> 2 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c b/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c
> index a17c423a526d..c48b2ce7c4a3 100644
> --- a/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c
> +++ b/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.c
> @@ -94,26 +94,26 @@ static void hisi_ptt_print_pkt(const unsigned char *buf, int pos, const char *de
>
> printf(".");
> color_fprintf(stdout, color, " %08x: ", pos);
> - for (i = 0; i < HISI_PTT_FIELD_LENTH; i++)
> + for (i = 0; i < HISI_PTT_FIELD_LENGTH; i++)
> color_fprintf(stdout, color, "%02x ", buf[pos + i]);
> for (i = 0; i < HISI_PTT_MAX_SPACE_LEN; i++)
> color_fprintf(stdout, color, " ");
> color_fprintf(stdout, color, " %s\n", desc);
> }
>
> -static int hisi_ptt_8dw_kpt_desc(const unsigned char *buf, int pos)
> +static int hisi_ptt_8dw_pkt_desc(const unsigned char *buf, int pos)
> {
> int i;
>
> for (i = 0; i < HISI_PTT_8DW_TYPE_MAX; i++) {
> /* Do not show 8DW check field and reserved fields */
> if (i == HISI_PTT_8DW_CHK_AND_RSV0 || i == HISI_PTT_8DW_RSV1) {
> - pos += HISI_PTT_FIELD_LENTH;
> + pos += HISI_PTT_FIELD_LENGTH;
> continue;
> }
>
> hisi_ptt_print_pkt(buf, pos, hisi_ptt_8dw_pkt_field_name[i]);
> - pos += HISI_PTT_FIELD_LENTH;
> + pos += HISI_PTT_FIELD_LENGTH;
> }
>
> return hisi_ptt_pkt_size[HISI_PTT_8DW_PKT];
> @@ -128,7 +128,7 @@ static void hisi_ptt_4dw_print_dw0(const unsigned char *buf, int pos)
> dw0.value = *(uint32_t *)(buf + pos);
> printf(".");
> color_fprintf(stdout, color, " %08x: ", pos);
> - for (i = 0; i < HISI_PTT_FIELD_LENTH; i++)
> + for (i = 0; i < HISI_PTT_FIELD_LENGTH; i++)
> color_fprintf(stdout, color, "%02x ", buf[pos + i]);
> for (i = 0; i < HISI_PTT_MAX_SPACE_LEN; i++)
> color_fprintf(stdout, color, " ");
> @@ -140,16 +140,16 @@ static void hisi_ptt_4dw_print_dw0(const unsigned char *buf, int pos)
> dw0.len, "Time", dw0.time);
> }
>
> -static int hisi_ptt_4dw_kpt_desc(const unsigned char *buf, int pos)
> +static int hisi_ptt_4dw_pkt_desc(const unsigned char *buf, int pos)
> {
> int i;
>
> hisi_ptt_4dw_print_dw0(buf, pos);
> - pos += HISI_PTT_FIELD_LENTH;
> + pos += HISI_PTT_FIELD_LENGTH;
>
> for (i = 0; i < HISI_PTT_4DW_TYPE_MAX; i++) {
> hisi_ptt_print_pkt(buf, pos, hisi_ptt_4dw_pkt_field_name[i]);
> - pos += HISI_PTT_FIELD_LENTH;
> + pos += HISI_PTT_FIELD_LENGTH;
> }
>
> return hisi_ptt_pkt_size[HISI_PTT_4DW_PKT];
> @@ -158,7 +158,7 @@ static int hisi_ptt_4dw_kpt_desc(const unsigned char *buf, int pos)
> int hisi_ptt_pkt_desc(const unsigned char *buf, int pos, enum hisi_ptt_pkt_type type)
> {
> if (type == HISI_PTT_8DW_PKT)
> - return hisi_ptt_8dw_kpt_desc(buf, pos);
> + return hisi_ptt_8dw_pkt_desc(buf, pos);
>
> - return hisi_ptt_4dw_kpt_desc(buf, pos);
> + return hisi_ptt_4dw_pkt_desc(buf, pos);
> }
> diff --git a/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.h b/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.h
> index e78f1b5bc836..6772b16b817b 100644
> --- a/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.h
> +++ b/tools/perf/util/hisi-ptt-decoder/hisi-ptt-pkt-decoder.h
> @@ -13,7 +13,7 @@
> #define HISI_PTT_8DW_CHECK_MASK GENMASK(31, 11)
> #define HISI_PTT_IS_8DW_PKT GENMASK(31, 11)
> #define HISI_PTT_MAX_SPACE_LEN 10
> -#define HISI_PTT_FIELD_LENTH 4
> +#define HISI_PTT_FIELD_LENGTH 4
>
> enum hisi_ptt_pkt_type {
> HISI_PTT_4DW_PKT,
More information about the linux-arm-kernel
mailing list