[PATCH 04/13] arm64: dts: exynos8855: add cmu_top & cmu_peric clock DT nodes
Alim Akhtar
alim.akhtar at samsung.com
Tue Jul 28 05:23:37 PDT 2026
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: Tuesday, July 28, 2026 5:30 PM
> To: raghav.s <raghav.s at samsung.com>; s.nawrocki at samsung.com;
> cw00.choi at samsung.com; peter.griffin at linaro.org;
> alim.akhtar at samsung.com; mturquette at baylibre.com; sboyd at kernel.org;
> bmasney at redhat.com; robh at kernel.org; conor+dt at kernel.org
> Cc: linux-samsung-soc at vger.kernel.org; linux-clk at vger.kernel.org;
> devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
> kernel at vger.kernel.org; hajun.sung at samsung.com;
> is.gandhi at samsung.com; ts.amit at samsung.com;
> pokala.reddy at samsung.com
> Subject: Re: [PATCH 04/13] arm64: dts: exynos8855: add cmu_top &
> cmu_peric clock DT nodes
>
> On 28/07/2026 14:11, raghav.s wrote:
> > Add required dt node for cmu_top & cmu_peric block
> >
> > Signed-off-by: raghav.s <raghav.s at samsung.com>
> > ---
> > arch/arm64/boot/dts/exynos/exynos8855.dtsi | 24
> > ++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
>
> Please organize your patches in reasonable order. DTS is never in the middle,
> see submitting patches (both documents) and maintainer-soc profile.
>
The thought was to add clks block wise and hence we see DTS coming in between but for the other blocks.
e.g. patch-2 and 3 adds binding and driver for TOP and PERIC and this patch-4 adds DTS.
And patch-5 and 6 adds binding and driver for PERIS and patch-7 adds DTS and so on.
Cover-letter should have explained this.
Are you suggesting to re-order all the binding first followed by all blocks driver and then add a single DTS for all clock controller?
Does current approach helps in review?
> Best regards,
> Krzysztof
More information about the linux-arm-kernel
mailing list