[PATCH v15 4/5] gpio: rpmsg: add generic rpmsg GPIO driver
Uwe Kleine-König
u.kleine-koenig at baylibre.com
Wed Jul 22 23:33:02 PDT 2026
Hello,
On Tue, Jul 21, 2026 at 03:46:47PM -0500, Shenwei Wang wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/rpmsg.h>
<linux/rpmsg.h> includes <linux/device-id/rpmsg.h> and thus provides
rpmsg_device_id already. So please drop the include for
<linux/mod_devicetable.h> which will go away soon.
> +static struct rpmsg_device_id rpmsg_gpio_channel_id_table[] = {
> + { .name = CHAN_NAME_PREFIX },
> + { },
no trailing comma after the list terminator please.
> +};
Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20260723/5b4a22c5/attachment.sig>
More information about the linux-arm-kernel
mailing list