[PATCH v2] soc: xilinx: Remove redundant dev_err()
Michal Simek
michal.simek at amd.com
Wed Jul 22 06:14:27 PDT 2026
On 7/22/26 04:35, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang at vivo.com>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey at amd.com>
> Acked-by: Michal Simek <michal.simek at amd.com>
> ---
> drivers/soc/xilinx/zynqmp_power.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
> index 370e61ac47d8..54c796afb89e 100644
> --- a/drivers/soc/xilinx/zynqmp_power.c
> +++ b/drivers/soc/xilinx/zynqmp_power.c
> @@ -368,11 +368,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
> IRQF_NO_SUSPEND | IRQF_ONESHOT,
> dev_name(&pdev->dev),
> &pdev->dev);
> - if (ret) {
> - dev_err(&pdev->dev, "devm_request_threaded_irq '%d' failed with %d\n",
> - irq, ret);
> + if (ret)
> return ret;
> - }
> } else {
> dev_err(&pdev->dev, "Required property not found in DT node\n");
> return -ENOENT;
But you still send it as threaded not really separate emails.
When you pass this message-id I am getting ti patch not xilinx one.
Thanks,
Michal
b4 am -l 20260722023523.42269-7-panchuang at vivo.com
Looking up 20260722023523.42269-7-panchuang at vivo.com
Analyzing 8 messages in the thread
WARNING: duplicate messages found at index 1
Subject 1: soc/tegra: cbb: Remove redundant dev_err()
Subject 2: soc: xilinx: Remove redundant dev_err()
2 is not a reply... assume additional patch
WARNING: duplicate messages found at index 1
Subject 1: soc: qcom: Remove redundant dev_err()
Subject 2: soc/tegra: cbb: Remove redundant dev_err()
2 is not a reply... assume additional patch
WARNING: duplicate messages found at index 1
Subject 1: soc: fsl: dpio: Remove redundant dev_err()
Subject 2: soc: qcom: Remove redundant dev_err()
2 is not a reply... assume additional patch
Assuming new revision: v2 ([PATCH v2] soc: ixp4xx: Remove redundant dev_err())
Assuming new revision: v2 ([PATCH v2] soc: mediatek: mtk-svs: Remove redundant
dev_err_probe())
Assuming new revision: v2 ([PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant
dev_err())
Looking for additional code-review trailers on lore.kernel.org
Analyzing 13 code-review messages
Checking attestation on all messages, may take a moment...
---
✓ [PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant dev_err()
+ Link: https://patch.msgid.link/20260722023523.42269-6-panchuang@vivo.com
---
✓ Signed: DKIM/vivo.com
---
Total patches: 1
---
Link: https://patch.msgid.link/20260722023523.42269-6-panchuang@vivo.com
git am
./v2_20260722_panchuang_soc_ti_wkup_m3_ipc_remove_redundant_dev_err.mbx
More information about the linux-arm-kernel
mailing list