[PATCH 2/2] ASoC: meson: meson-card: use priv instead of card on each functions
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Tue Jul 21 16:22:08 PDT 2026
Hi Jerome
Thank you for your review
> > We can get card via priv->card, use priv for function param.
> > No functional change, but is preparation for Card capsuling.
>
> The change is simple but it will make more complex to backport fix an
> older kernel once this fix is applied. So again, getting more context to
> understand what you are trying to accomplish and why it needs a standard
> card variable name would help.
Basically, after "Card capsuling" has done, we can't directly use card->xxx
anymore. So we need to update all of such code.
I would like to update such code as much as possible in advance.
Otherwise, "Card capsuling" patch itself will be more complex and difficult
to review.
But looking at the code again, indeed it is some rather exaggerated changes.
I think v2 can be more simple.
About [1/2], I have noticed that there is meson_card_parse_of_optional(),
but snd_soc_card_driver_of_parse_aux_devs() case didn't use it.
I wondered if it was a mistake not to use it, even though it was the same
pattern. Not a big-deal. If it is intentional, there is no problem.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
More information about the linux-arm-kernel
mailing list