[PATCH v2] KVM: arm64: Fix hyp_trace clock disabling

Marc Zyngier maz at kernel.org
Mon Jul 20 23:52:28 PDT 2026


On Mon, 20 Jul 2026 20:45:00 +0100,
Fuad Tabba <fuad.tabba at linux.dev> wrote:
> 
> Hi Vincent,
> 
> On Wed, 15 Jul 2026 at 11:51, Vincent Donnefort <vdonnefort at google.com> wrote:
> >
> > Fix the disable path in hyp_trace_clock_enable(), which fell through to
> > re-initialize and reschedule the clock after cancelling the work. Return
> > early instead.
> >
> > While at it, cleanup hyp_trace_clock::lock which is unused and
> > hyp_trace_clock::running which is redundant: the trace_remote framework
> > already serializes calls to the callback enable_tracing.
> 
> Although the cleanup and the fix are to the same commit, could this be
> split into the fix and the lock/running cleanup as a separate patch?
> Since b22888917fa41 is already in a released kernel, the fix will
> likely go to stable, and it'd be nice to keep that backport to just
> the behavioural change.

Not sure I get what you mean here. From what I can see, this patch
fully applies to b22888917fa41. Given that this is the third version
for something that trivial (two from Vincent, one from you), can we
please agree on *something* quickly?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.



More information about the linux-arm-kernel mailing list