[PATCH] net: stmmac: dwmac4: mask interrupts before stopping DMA in suspend

luis.la at mail.de luis.la at mail.de
Mon Jul 20 04:24:21 PDT 2026


Hi Maxime,
> This is almost perfect for a new submission, only 2 things to improve :
> 
>  - you're missing the tree name in the patch subject. As this is a fix, it should be :
> 
>    [PATCH net] net: stmmac: dwmac4: mask interrupts before stopping DMA in suspend
> 
>    you can find instructions for this in the doc Andrew linked :
> 
>    https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> 
>  - When submitting a patch, do so in a dedicated thread, and not in reply to
>    other threads.
> 
> You should send a V2 addressing the tree name in the patch subject.

Thanks for the feedback, I addressed these changes and sent a v2 patch.

> Sashiko noted something on the patch :
> 
>   https://sashiko.dev/#/patchset/20260718152802.83553-1-luis.la%40mail.de
> 
> It looks to me that sashiko is just wrong there though, I can't make sense
> of what it is saying.

This seems to be because strictly speaking the title of the commit was wrong,
the interrupts don't get deactivated before stopping dma.
I changed it, but only read after that it is discouraged to change the Subject, sorry...
I hope the patch now meets the requirements,
Luis




More information about the linux-arm-kernel mailing list