[PATCH v2] ARM: lpc32xx: only run SoC init on LPC32xx hardware
Vladimir Zapolskiy
vz at mleia.com
Thu Jul 16 16:00:55 PDT 2026
On 7/14/26 09:12, Arnd Bergmann wrote:
> On Mon, Jul 13, 2026, at 21:25, Karl Mehltretter wrote:
>> lpc32xx_check_uid() and lpc32xx_pm_init() are arch_initcalls that poke
>> LPC32xx-only registers. Since the multiplatform conversion they also
>> run on other ARCH_MULTI_V5 boards where access faults e.g. on versatile:
>>
>> Unable to handle kernel paging request at virtual address f4004130
>> PC is at lpc32xx_check_uid+0x2c/0x9c
>>
>> Drop the arch_initcall() registrations and call both functions directly
>> from lpc3250_machine_init(), the machine's .init_machine hook.
>> The calls are placed in link order (common.c, pm.c, phy3250.c) to
>> keep their previous relative ordering.
>>
>> Fixes: 75bf1bd7d2f9 ("ARM: lpc32xx: allow multiplatform build")
>> Suggested-by: Arnd Bergmann <arnd at arndb.de>
>> Signed-off-by: Karl Mehltretter <kmehltretter at gmail.com>
>
> Looks good to me,
>
> Reviewed-by: Arnd Bergmann <arnd at arndb.de>
>
> Vladimir, I assume you'll pick this up and forward it to
> soc at lists.linux.dev. Let us know if you prefer Karl to send it
> there directly and save you the extra pull request.
Will do it next week, if it's not too late.
Many thanks for the change and for the review!
--
Best wishes,
Vladimir
More information about the linux-arm-kernel
mailing list