[PATCH 05/18] thermal/drivers/imx: Remove redundant dev_err()

Frank Li Frank.li at oss.nxp.com
Wed Jul 8 20:38:03 PDT 2026


On Thu, Jul 09, 2026 at 10:30:08AM +0800, Pan Chuang wrote:
>
> The devm_request_threaded_irq() now automatically logs detailed error
> messages on failure. This eliminates the need for driver-specific
> dev_err() calls that previously printed generic messages.
>
> Signed-off-by: Pan Chuang <panchuang at vivo.com>
> ---

Reviewed-by: Frank Li <Frank.Li at nxp.com>

>  drivers/thermal/imx_thermal.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
> index 5aaacbc53478..416d89c6287a 100644
> --- a/drivers/thermal/imx_thermal.c
> +++ b/drivers/thermal/imx_thermal.c
> @@ -732,10 +732,8 @@ static int imx_thermal_probe(struct platform_device *pdev)
>         ret = devm_request_threaded_irq(dev, data->irq,
>                         imx_thermal_alarm_irq, imx_thermal_alarm_irq_thread,
>                         0, "imx_thermal", data);
> -       if (ret < 0) {
> -               dev_err(dev, "failed to request alarm irq: %d\n", ret);
> +       if (ret < 0)
>                 goto thermal_zone_unregister;
> -       }
>
>         pm_runtime_put(data->dev);
>
> --
> 2.34.1
>
>



More information about the linux-arm-kernel mailing list