[PATCH 2/3] spi: atmel-quadspi: Simplify with dev_err_probe()
Krzysztof Kozlowski
krzysztof.kozlowski at oss.qualcomm.com
Sun Jul 5 10:27:39 PDT 2026
Use dev_err_probe() to make error code handling simpler and handle
deferred probe nicely (avoid spamming logs).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at oss.qualcomm.com>
---
drivers/spi/atmel-quadspi.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index 8d9c77f5de43..e3a4697fabce 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -1413,20 +1413,15 @@ static int atmel_qspi_probe(struct platform_device *pdev)
if (aq->caps->has_qspick) {
/* Get the QSPI system clock */
aq->qspick = devm_clk_get_enabled(dev, "qspick");
- if (IS_ERR(aq->qspick)) {
- dev_err(&pdev->dev, "missing system clock\n");
- err = PTR_ERR(aq->qspick);
- return err;
- }
-
+ if (IS_ERR(aq->qspick))
+ return dev_err_probe(dev, PTR_ERR(aq->qspick),
+ "missing system clock\n");
} else if (aq->caps->has_gclk) {
/* Get the QSPI generic clock */
aq->gclk = devm_clk_get(dev, "gclk");
- if (IS_ERR(aq->gclk)) {
- dev_err(&pdev->dev, "missing Generic clock\n");
- err = PTR_ERR(aq->gclk);
- return err;
- }
+ if (IS_ERR(aq->gclk))
+ return dev_err_probe(dev, PTR_ERR(aq->gclk),
+ "missing Generic clock\n");
}
if (aq->caps->has_dma) {
--
2.53.0
More information about the linux-arm-kernel
mailing list