[PATCH v4 1/6] irqchip/gic-v3-its: Fix memleak in its_probe_one()
Radu Rendec
radu at rendec.net
Sat Jul 4 07:51:09 PDT 2026
On Thu, 2026-07-02 at 11:30 +0800, Kemeng Shi wrote:
> Fix collection leak when its_init_domain() failed in its_probe_one().
>
> Fixes: 4c21f3c26ecc2 ("irqchip: GICv3: ITS: DT probing and initialization")
> Signed-off-by: Kemeng Shi <shikemeng at huaweicloud.com>
> ---
> drivers/irqchip/irq-gic-v3-its.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 291d7668cc8d..d721b6101e0a 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -5326,7 +5326,7 @@ static int __init its_probe_one(struct its_node *its)
>
> err = its_init_domain(its);
> if (err)
> - goto out_free_tables;
> + goto out_free_col;
>
> raw_spin_lock(&its_lock);
> list_add(&its->entry, &its_nodes);
> @@ -5334,6 +5334,8 @@ static int __init its_probe_one(struct its_node *its)
>
> return 0;
>
> +out_free_col:
> + kfree(its->collections);
> out_free_tables:
> its_free_tables(its);
> out_free_cmd:
Reviewed-by: Radu Rendec <radu at rendec.net>
More information about the linux-arm-kernel
mailing list